This is an archive of the discontinued LLVM Phabricator instance.

Differential D9544

Escape strings in disassembly comments.
ClosedPublic

Authored by ki.stfu on May 6 2015, 5:38 PM.

Details

Reviewers
ChuckR
abidh
Commits
rGf44ab29e05a3: Escape strings in disassembly comments.
rLLDB237092: Escape strings in disassembly comments.
rL237092: Escape strings in disassembly comments.
Summary

Patch from chuckr@microsoft.com

Diff Detail

Event Timeline

ChuckR updated this revision to Diff 25114.May 6 2015, 5:38 PM
ChuckR retitled this revision from to Escape strings in disassembly comments..
ChuckR updated this object.
ChuckR edited the test plan for this revision. (Show Details)
ChuckR added reviewers: abidh, ki.stfu.
ChuckR added subscribers: Unknown Object (MLST), paulmaybee.
ki.stfu requested changes to this revision.May 6 2015, 10:14 PM
ki.stfu edited edge metadata.

Provide a test case for that please.

This revision now requires changes to proceed.May 6 2015, 10:14 PM
ChuckR updated this revision to Diff 25241.May 7 2015, 2:45 PM
ChuckR edited edge metadata.

Added test for escaped characters in disassembly comments

ki.stfu accepted this revision.May 7 2015, 9:09 PM
ki.stfu edited edge metadata.
This revision is now accepted and ready to land.May 7 2015, 9:09 PM
ki.stfu added a comment.May 7 2015, 10:36 PM

BTW, it will be fine if you merge the data-disassemble tests into 1. Can you do that?

ChuckR updated this revision to Diff 25353.May 8 2015, 11:18 AM
ChuckR edited edge metadata.

Merge the new disassembly test into the original

ki.stfu added a comment.May 9 2015, 1:58 AM

Lgtm

ChuckR added a comment.May 11 2015, 10:50 AM

Can somebody please check this in?

ki.stfu commandeered this revision.May 11 2015, 10:56 PM
ki.stfu edited reviewers, added: ChuckR; removed: ki.stfu.
This revision now requires review to proceed.May 11 2015, 10:56 PM
ki.stfu updated this revision to Diff 25549.May 11 2015, 10:57 PM

Rebase against ToT

ki.stfu updated this object.May 11 2015, 10:57 PM
Closed by commit rL237092: Escape strings in disassembly comments. (authored by ki.stfu). · Explain WhyMay 11 2015, 10:59 PM
This revision was automatically updated to reflect the committed changes.
ChuckR edited edge metadata.May 11 2015, 11:56 PM

Thank you.

Revision Contents

PathSize
tools/
lldb-mi/
2 lines

Diff 25114

tools/lldb-mi/MICmdCmdData.cpp

Context not available.
const CMICmnMIValueConst miValueConst4(CMIUtilString::Format("%d", instrtSize)); const CMICmnMIValueConst miValueConst4(CMIUtilString::Format("%d", instrtSize));
const CMICmnMIValueResult miValueResult4("size", miValueConst4); const CMICmnMIValueResult miValueResult4("size", miValueConst4);
miValueTuple.Add(miValueResult4); miValueTuple.Add(miValueResult4);
const CMICmnMIValueConst miValueConst5(CMIUtilString::Format("%s %s%s", pStrMnemonic, pStrOperands, strComment.c_str())); const CMICmnMIValueConst miValueConst5(CMIUtilString::Format("%s %s%s", pStrMnemonic, pStrOperands, strComment.Escape(true).c_str()));
const CMICmnMIValueResult miValueResult5("inst", miValueConst5); const CMICmnMIValueResult miValueResult5("inst", miValueConst5);
miValueTuple.Add(miValueResult5); miValueTuple.Add(miValueResult5);
Context not available.