This is an archive of the discontinued LLVM Phabricator instance.

[doc] Use cmake's -S option to simplify the build instructions
ClosedPublic

Authored by ebraminio on Jan 20 2021, 7:38 AM.

Details

Reviewers
evandro
ebraminio
Summary

Now that llvm's minimum version is 3.13.4 anyway and -S is
introduced in the same version[1], let's use this little
time saving option to simplify the build instructions.

[1]: https://cgold.readthedocs.io/en/latest/glossary/-S.html

Diff Detail

Event Timeline

ebraminio requested review of this revision.Jan 20 2021, 7:38 AM
ebraminio created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2021, 7:38 AM
evandro accepted this revision.Jan 22 2021, 2:07 PM
This revision is now accepted and ready to land.Jan 22 2021, 2:07 PM

Thanks for the review :) So guess can be merged now?

Thanks for the review :) So guess can be merged now?

Yes, once accepted, one can commit a patch under review.

ebraminio accepted this revision.Feb 15 2021, 11:21 PM

From https://llvm.org/docs/Phabricator.html

It is sufficient to add a comment to the approved review indicating you cannot commit the patch yourself.

"I can't commit the patch myself" So here it is :)

P.S.

Wished to upload some other patches in the meanwhile but got busy with other things yet feel this minor thing reduces time to begin for others.

evandro closed this revision.Feb 16 2021, 1:44 PM