[llgo] add USES_TERMINAL option to check-libgo

[axw]

Summary

The check-libgo target runs "make check" in the
libgo package, which can take a long time on
slower machines. To prevent buildbot failures
due to timeout, we can use Ninja's console pool
for this target.

[pcc]

The last time I tried this I ran into some bug in ninja that caused the rule not to terminate, and I never got around to investigating it. I just tried again and saw the same problem. Does it work for you?

[pcc]

https://github.com/martine/ninja/issues/965

[axw]

In D9495#166115, @pcc wrote:

The last time I tried this I ran into some bug in ninja that caused the rule not to terminate, and I never got around to investigating it. I just tried again and saw the same problem. Does it work for you?

No, sorry, I hadn't run it to completion. I just confirmed that it wasn't buffering. I'll take a look at Ninja later, thanks.

[axw]

@pcc the newer gofrontend revision has the necessary fixes. check-libgo no longer hangs, and prints out results as they're available. OK to land now?

[axw]

Ping.

[pcc]

LGTM

llgo/trunk/CMakeLists.txt

install(FILES ${LLGO_LIBRARY_DIR}/libgo-llgo.a
         DESTINATION lib${LLVM_LIBDIR_SUFFIX})
 
 install(DIRECTORY ${LLGO_LIBRARY_DIR}/go
         DESTINATION lib${LLVM_LIBDIR_SUFFIX})
 
 add_custom_target(check-libgo
   COMMAND make -C ${CMAKE_CURRENT_BINARY_DIR}/libgo -j${PROCESSOR_COUNT} check
   DEPENDS libgo
+  ${cmake_3_2_USES_TERMINAL}
   COMMENT "Running libgo tests")
 
 add_custom_target(check-llgo-bootstrap
   COMMAND strip -R .note.gnu.build-id -o ${CMAKE_CURRENT_BINARY_DIR}/llgo-stage2.stripped
           ${CMAKE_BINARY_DIR}/bin/llgo-stage2${CMAKE_EXECUTABLE_SUFFIX}
   COMMAND strip -R .note.gnu.build-id -o ${CMAKE_CURRENT_BINARY_DIR}/llgo-stage3.stripped
           ${CMAKE_BINARY_DIR}/bin/llgo-stage3${CMAKE_EXECUTABLE_SUFFIX}
   COMMAND cmp ${CMAKE_CURRENT_BINARY_DIR}/llgo-stage2.stripped
           ${CMAKE_CURRENT_BINARY_DIR}/llgo-stage3.stripped
   DEPENDS llgo-stage2 llgo-stage3
   COMMENT "Checking llgo bootstrap")
 
 add_subdirectory(test)