Page MenuHomePhabricator

[lldb] Bump the required SWIG version to 3
ClosedPublic

Authored by JDevlieghere on Jan 7 2021, 10:27 AM.

Details

Reviewers
teemperor
Group Reviewers
Restricted Project
Commits
rGcb6d53ccdc72: [lldb] Bump the required SWIG version to 3
Summary

Bump the required SWIG version to 3. If my memory serves me well we last bumped the required SWIG version to 2 for Python 3. At that time SWIG 3 had already been around for a while so everyone I know was already using that.

It appears that SWIG 3 is the only version that officially supports C++11 which we're using in the typemap. SWIG 3 was released in 2014 so I think it's reasonable to make that the minimally supported version.

https://bugs.llvm.org/show_bug.cgi?id=48685

Diff Detail

Event Timeline

JDevlieghere created this revision.Jan 7 2021, 10:27 AM
JDevlieghere requested review of this revision.Jan 7 2021, 10:27 AM
teemperor accepted this revision.Jan 8 2021, 5:22 AM
teemperor added a subscriber: teemperor.

LGTM modulo the warning messages still referencing 2 instead of 3.

lldb/cmake/modules/FindLuaAndSwig.cmake
20

SWIG 3

lldb/cmake/modules/FindPythonAndSwig.cmake
45

"SWIG 3 or later ..." as pointed out in the bug report.

This revision is now accepted and ready to land.Jan 8 2021, 5:22 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2021, 8:54 AM