This is an archive of the discontinued LLVM Phabricator instance.

Differential D9413

Proposed Resolution for LWG Issue #2458: N3778 and new library deallocation signatures
ClosedPublic

Authored by mclow.lists on Apr 30 2015, 11:49 AM.

Details

Reviewers
EricWF
Summary

http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-active.html#2458

Diff Detail

Event Timeline

mclow.lists updated this revision to Diff 24761.Apr 30 2015, 11:49 AM
mclow.lists retitled this revision from to Proposed Resolution for LWG Issue #2458: N3778 and new library deallocation signatures.
mclow.lists updated this object.
mclow.lists edited the test plan for this revision. (Show Details)
mclow.lists added a reviewer: EricWF.
mclow.lists added a subscriber: Unknown Object (MLST).
EricWF accepted this revision.Apr 30 2015, 6:15 PM
EricWF edited edge metadata.

We should removed the tests libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete_nothrow_replace.pass.cpp and libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_nothrow_replace.pass.cpp

Other than that LGTM.

This revision is now accepted and ready to land.Apr 30 2015, 6:15 PM
mclow.lists added a comment.May 1 2015, 6:34 PM

I've updated my local patch to remove those two files. I don't see the need to upload a new patch here, though.

Thanks!

mclow.lists closed this revision.May 18 2015, 11:29 AM

Committed as 237592

Revision Contents

PathSize
include/
4 lines
src/
14 lines

Diff 24761

include/new

Context not available.
void operator delete(void* ptr) noexcept; // replaceable void operator delete(void* ptr) noexcept; // replaceable
void operator delete(void* ptr, std::size_t size) noexcept; // replaceable, C++14 void operator delete(void* ptr, std::size_t size) noexcept; // replaceable, C++14
void operator delete(void* ptr, const std::nothrow_t&) noexcept; // replaceable void operator delete(void* ptr, const std::nothrow_t&) noexcept; // replaceable
void operator delete(void* ptr, std::size_t size,
const std::nothrow_t&) noexcept; // replaceable, C++14
void* operator new[](std::size_t size); // replaceable void* operator new[](std::size_t size); // replaceable
void* operator new[](std::size_t size, const std::nothrow_t&) noexcept; // replaceable void* operator new[](std::size_t size, const std::nothrow_t&) noexcept; // replaceable
void operator delete[](void* ptr) noexcept; // replaceable void operator delete[](void* ptr) noexcept; // replaceable
void operator delete[](void* ptr, std::size_t size) noexcept; // replaceable, C++14 void operator delete[](void* ptr, std::size_t size) noexcept; // replaceable, C++14
void operator delete[](void* ptr, const std::nothrow_t&) noexcept; // replaceable void operator delete[](void* ptr, const std::nothrow_t&) noexcept; // replaceable
void operator delete[](void* ptr, std::size_t size,
const std::nothrow_t&) noexcept; // replaceable, C++14
void* operator new (std::size_t size, void* ptr) noexcept; void* operator new (std::size_t size, void* ptr) noexcept;
void* operator new[](std::size_t size, void* ptr) noexcept; void* operator new[](std::size_t size, void* ptr) noexcept;
Context not available.

src/new.cpp

Context not available.
_LIBCPP_WEAK _LIBCPP_NEW_DELETE_VIS _LIBCPP_WEAK _LIBCPP_NEW_DELETE_VIS
void void
operator delete(void* ptr, size_t, const std::nothrow_t& nt) _NOEXCEPT
{
::operator delete(ptr, nt);
}
_LIBCPP_WEAK _LIBCPP_NEW_DELETE_VIS
void
operator delete[] (void* ptr) _NOEXCEPT operator delete[] (void* ptr) _NOEXCEPT
{ {
::operator delete(ptr); ::operator delete(ptr);
Context not available.
::operator delete[](ptr); ::operator delete[](ptr);
} }
_LIBCPP_WEAK _LIBCPP_NEW_DELETE_VIS
void
operator delete[] (void* ptr, size_t, const std::nothrow_t& nt) _NOEXCEPT
{
::operator delete[](ptr, nt);
}
#endif // !__GLIBCXX__ #endif // !__GLIBCXX__
namespace std namespace std
Context not available.