This is an archive of the discontinued LLVM Phabricator instance.

Differential D93934

[Transforms][Utils] remove useless variable in CloneBasicBlock
Needs ReviewPublic

Authored by dongAxis1944 on Dec 29 2020, 11:04 PM.

Details

Reviewers
loladiro
Summary

variable named Cache does not use anymore in CloneBasicBlock, so we use the patch to remove it

Diff Detail

Event Timeline

dongAxis1944 created this revision.Dec 29 2020, 11:04 PM
Herald added a subscriber: hiraditya. · View Herald TranscriptDec 29 2020, 11:04 PM
dongAxis1944 requested review of this revision.Dec 29 2020, 11:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 29 2020, 11:04 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
dongAxis1944 retitled this revision from [Transforms][Utils] remove useless variable to [Transforms][Utils] remove useless variable in CloneBasicBlock.Dec 29 2020, 11:05 PM

Revision Contents

PathSize
llvm/
lib/
Transforms/
Utils/
1 line

Diff 314073

llvm/lib/Transforms/Utils/CloneFunction.cpp

Show All 35 Lines
#include <map> #include <map>
using namespace llvm; using namespace llvm;
/// See comments in Cloning.h. /// See comments in Cloning.h.
BasicBlock *llvm::CloneBasicBlock(const BasicBlock *BB, ValueToValueMapTy &VMap, BasicBlock *llvm::CloneBasicBlock(const BasicBlock *BB, ValueToValueMapTy &VMap,
const Twine &NameSuffix, Function *F, const Twine &NameSuffix, Function *F,
ClonedCodeInfo *CodeInfo, ClonedCodeInfo *CodeInfo,
DebugInfoFinder *DIFinder) { DebugInfoFinder *DIFinder) {
DenseMap<const MDNode *, MDNode *> Cache;
BasicBlock *NewBB = BasicBlock::Create(BB->getContext(), "", F); BasicBlock *NewBB = BasicBlock::Create(BB->getContext(), "", F);
if (BB->hasName()) if (BB->hasName())
NewBB->setName(BB->getName() + NameSuffix); NewBB->setName(BB->getName() + NameSuffix);
bool hasCalls = false, hasDynamicAllocas = false; bool hasCalls = false, hasDynamicAllocas = false;
Module *TheModule = F ? F->getParent() : nullptr; Module *TheModule = F ? F->getParent() : nullptr;
// Loop over all instructions, and copy them over. // Loop over all instructions, and copy them over.
▲ Show 20 Lines • Show All 833 Lines • Show Last 20 Lines