Page MenuHomePhabricator

Fix float->uint conversion for inputs less than 0
ClosedPublic

Authored by dschuff on Apr 27 2015, 2:22 PM.

Details

Summary

The spec for these functions says that they should return 0 in this case but
this regressed in r234148. That revision essentially delegates the conversion
to the hardware, but that has different behavior on different platforms (e.g.
it is wrong on x86).

Also fix a typo in the name of __fixunsdfti

Diff Detail

Event Timeline

dschuff updated this revision to Diff 24504.Apr 27 2015, 2:22 PM
dschuff retitled this revision from to Fix float->uint conversion for inputs less than 0.
dschuff updated this object.
dschuff edited the test plan for this revision. (Show Details)
dschuff added reviewers: joerg, howard.hinnant.
dschuff added a subscriber: Unknown Object (MLST).

ping! any takers?

Since this is a pretty trivial fix for a pretty clear regression and violation of the compiler-rt/libgcc spec (such as it is), I'm just going to go ahead and land this. Post-commit review is welcome.

This revision was automatically updated to reflect the committed changes.