Add -data-info-line command + test
Details
Diff Detail
Event Timeline
Is it a standard GDB/MI command? If so, then can you point me to its documentation. If it is some extension, can you please document it with its options in the extensions file.
tools/lldb-mi/MICmdCmdData.h | ||
---|---|---|
378 | Please remove Author name. |
Remove Authors/Gotchas/Changes and add -data-info-line command specification into MIExtensions.txt
I can understand the usefulness of this thing. We use to have something similar internally where you can hover over a source line and the you will get information about it in tool tip. But my concern is that you are relying on the output of a CLI command. A small change in its format will break this command. Is it possible to get this information from API?
test/tools/lldb-mi/data/TestMiData.py | ||
---|---|---|
166 | It would be good to add a case which does not resolve too. | |
tools/lldb-mi/MICmdCmdData.cpp | ||
1703 | It would be good to put some comment at this location telling that column can be optional and how you are handling that. | |
1742 | I think you need to give better error message in case when lldb can not find the location. On my system, I get the following. -data-info-line *0x00000000001 Which is not very helpful. I think it would be better to just print ^done without any data telling that location was not resolved instead of error. | |
tools/lldb-mi/MIExtensions.txt | ||
20 ↗ | (On Diff #24548) | How about this. The output of this command contains the following fields: |
24 ↗ | (On Diff #24548) | Please complete the line. |
25 ↗ | (On Diff #24548) | I dont understand what the above line means. |
tools/lldb-mi/MIExtensions.txt | ||
---|---|---|
24 ↗ | (On Diff #24548) | ugh.. It was deleted because of some mysterious reason... very strange. |
Fix a few comments, fix -data-info-line specification, improve test_lldbmi_data_info_line test, make an error message more helpful
Yep, I thought about this. Probably later I'll rework the -data-info-line command to use only LLDB API.
It would be good to add a case which does not resolve too.