This is an archive of the discontinued LLVM Phabricator instance.

[libc++] [docs] Mark LWG3055 as complete. Use string_view instead of string in path::operator+=(ECharT).
ClosedPublic

Authored by curdeius on Dec 6 2020, 8:41 AM.

Details

Summary

The issue didn't change the behaviour which is tested in libcxx/test/std/input.output/filesystems/class.path/path.member/path.concat.pass.cpp.

The change to use string_view instead of string is not strictly necessary.

<filesystem> was added in commit 998a5c88312066fcc2b2de1358edc76587611354 (Implement <filesystem>).

Diff Detail

Event Timeline

curdeius requested review of this revision.Dec 6 2020, 8:41 AM
curdeius created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2020, 8:41 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
curdeius retitled this revision from [libc++] [docs] Mark LWG3055 as complete. Use string_view instead of string in path::operator+=(char). to [libc++] [docs] Mark LWG3055 as complete. Use string_view instead of string in path::operator+=(ECharT)..Dec 6 2020, 11:11 AM
curdeius edited the summary of this revision. (Show Details)
ldionne accepted this revision.Dec 7 2020, 10:04 AM
This revision is now accepted and ready to land.Dec 7 2020, 10:04 AM