This is an archive of the discontinued LLVM Phabricator instance.

[clang] Add a C++17 deduction guide testcase.
ClosedPublic

Authored by hokein on Dec 3 2020, 4:52 AM.

Diff Detail

Event Timeline

hokein created this revision.Dec 3 2020, 4:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2020, 4:52 AM
hokein requested review of this revision.Dec 3 2020, 4:52 AM
adamcz accepted this revision.Dec 3 2020, 7:20 AM

Thanks, adding this test is a very good idea.

clang/test/PCH/cxx17-deduction-guide-decl.cpp
17

You can drop these 3 lines, they're not needed for the crash repro. Also, c-tor doesn't have to be explicit. Probably best to keep the code as short as possible.

This revision is now accepted and ready to land.Dec 3 2020, 7:20 AM
hokein updated this revision to Diff 309469.Dec 4 2020, 12:01 AM

address comment, simplify the test.

clang/test/PCH/cxx17-deduction-guide-decl.cpp
17

yeah, thanks!

This revision was landed with ongoing or failed builds.Dec 4 2020, 12:07 AM
This revision was automatically updated to reflect the committed changes.