This is an archive of the discontinued LLVM Phabricator instance.

Add missing libraries to unittest link
ClosedPublic

Authored by labath on Apr 24 2015, 2:07 AM.

Download Raw Diff

Details

Reviewers

Commits

rG980b92a8e65b: Add missing libraries to unittest link
rLLDB235853: Add missing libraries to unittest link
rL235853: Add missing libraries to unittest link

Summary

Currently, linking of the unittests fails on linux because it is missing a bunch of symbols from
libedit, curses, etc. This fixes the build by adding the correct dependencies.

Diff Detail

Repository: rL LLVM

Event Timeline

labath updated this revision to Diff 24366.Apr 24 2015, 2:07 AM

labath retitled this revision from to Add missing libraries to unittest link.

labath updated this object.

labath edited the test plan for this revision. (Show Details)

labath added a reviewer: zturner.

labath added a subscriber: Unknown Object (MLST).

Looks good

Closed by commit rL235853: Add missing libraries to unittest link (authored by labath). · Explain WhyApr 27 2015, 2:29 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lldb/

trunk/

unittests/

CMakeLists.txt

2 lines

Diff 24459

lldb/trunk/unittests/CMakeLists.txt

Show All 17 Lines	add_unittest(LLDBUnitTests
${ARGN}		${ARGN}
)		)

if (MSVC)		if (MSVC)
target_link_libraries(${test_name} ${PYTHON_LIBRARY})		target_link_libraries(${test_name} ${PYTHON_LIBRARY})
endif()		endif()

lldb_link_common_libs(${test_name} EXE)		lldb_link_common_libs(${test_name} EXE)
target_link_libraries(${test_name} ${CLANG_USED_LIBS})		target_link_libraries(${test_name} ${CLANG_USED_LIBS} ${LLDB_SYSTEM_LIBS})
llvm_config(${test_name} ${LLVM_LINK_COMPONENTS})		llvm_config(${test_name} ${LLVM_LINK_COMPONENTS})
endfunction()		endfunction()

add_subdirectory(Host)		add_subdirectory(Host)
add_subdirectory(Interpreter)		add_subdirectory(Interpreter)
add_subdirectory(Plugins)		add_subdirectory(Plugins)
add_subdirectory(Utility)		add_subdirectory(Utility)