Page MenuHomePhabricator

[BatchAA] Reset entry when relying on cycle detection.
AbandonedPublic

Authored by asbirlea on Oct 23 2020, 11:00 AM.

Details

Reviewers
None
Summary

WIP
Do not cache values that rely on cycle detection, as this information cannot be carried from one query to the next.

Diff Detail

Unit TestsFailed

TimeTest
370 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -mcmodel=large -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/hwasan/TestCases/sizes.cpp -nostdlib++ -lstdc++ -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp

Event Timeline

asbirlea created this revision.Oct 23 2020, 11:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 23 2020, 11:00 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
asbirlea requested review of this revision.Oct 23 2020, 11:00 AM
nikic added a subscriber: nikic.Oct 23 2020, 11:33 AM

I've just pushed an extended test case in https://github.com/llvm/llvm-project/commit/1b65a51af80a9375ef85cb8fa6ec9ec3c68b3549, that shows that this problem is not BatchAA specific. We need to deal with this even for single queries, as results might have already been cached before we reach the phi.

Got it, thank you for the test and for catching this!

asbirlea abandoned this revision.Oct 23 2020, 3:57 PM

Abandoning in favor of D90066.