This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Fix the fs.op.absolute test to cope with windows paths
ClosedPublic

Authored by mstorsjo on Oct 22 2020, 3:36 AM.

Details

Summary

Prepend the root path on the already_absolute testcase, and construct a path ending with the preferred separator for the test reference for "foo/".

Additionally, the "" case fails both on MS STL and libstdc++, where it returns an empty string (and libstdc++ sets the error code). Unsure what to do with that one - make it libcpp specific, or consider the other implementations being wrong in thas aspect?

Diff Detail

Event Timeline

mstorsjo created this revision.Oct 22 2020, 3:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 22 2020, 3:36 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
mstorsjo requested review of this revision.Oct 22 2020, 3:36 AM
ldionne accepted this revision.Nov 2 2020, 3:03 PM
This revision is now accepted and ready to land.Nov 2 2020, 3:03 PM
This revision was landed with ongoing or failed builds.Nov 2 2020, 11:33 PM
This revision was automatically updated to reflect the committed changes.