Page MenuHomePhabricator

[libcxxabi] Stub out 'sleep' call when _LIBCXXABI_HAS_NO_THREADS is defined.
ClosedPublic

Authored by abidh on Oct 21 2020, 4:27 AM.

Details

Summary

While running this test on a bare metal target, I got an error as 'sleep' was not available on that system. As 'sleep' call is not doing anything useful for cases when _LIBCXXABI_HAS_NO_THREADS is defined. This patch puts it under this check.

Diff Detail

Event Timeline

abidh requested review of this revision.Oct 21 2020, 4:27 AM
abidh created this revision.
ldionne accepted this revision.Oct 21 2020, 5:23 AM

This sounds reasonable to me. Do you have commit access? If not, please specify Author Name <email@domain> I should use to commit on your behalf.

[...] Do you have commit access? If not, please specify Author Name <email@domain> I should use to commit on your behalf.

I see you do, feel free to go ahead and commit this. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Oct 21 2020, 12:59 PM
This revision was automatically updated to reflect the committed changes.
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2020, 12:59 PM