This is an archive of the discontinued LLVM Phabricator instance.

Differential D8945

LLD: Remove unused return vaules
ClosedPublic

Authored by ruiu on Apr 9 2015, 5:25 PM.

Details

Reviewers
shankarke
• shankar.easwaran
Summary

Remove unused return values.

Diff Detail

Event Timeline

ruiu updated this revision to Diff 23548.Apr 9 2015, 5:25 PM
ruiu retitled this revision from to LLD: Remove unused return vaules.
ruiu updated this object.
ruiu edited the test plan for this revision. (Show Details)
ruiu added a reviewer: shankarke.
ruiu set the repository for this revision to rL LLVM.
ruiu added a project: lld.
ruiu added a subscriber: Unknown Object (MLST).
• shankar.easwaran accepted this revision.Apr 9 2015, 5:46 PM
• shankar.easwaran added a reviewer: • shankar.easwaran.
This revision is now accepted and ready to land.Apr 9 2015, 5:46 PM
Eugene.Zelenko closed this revision.Sep 20 2016, 11:28 AM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Committed in r234556.

Revision Contents

PathSize
lib/
ReaderWriter/
ELF/
Hexagon/
85 lines

Diff 23548

lib/ReaderWriter/ELF/Hexagon/HexagonRelocationHandler.cpp

Show All 30 Lines if ((mask >> bit) & 1) {
uint32_t valBit = (val >> off) & 1; uint32_t valBit = (val >> off) & 1;
result |= valBit << bit; result |= valBit << bit;
++off; ++off;
} }
} }
return result; return result;
} }
static int relocBNPCREL(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A, static void relocBNPCREL(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A,
int32_t nBits) { int32_t nBits) {
int32_t result = (uint32_t)(((S + A) - P) >> 2); int32_t result = (uint32_t)(((S + A) - P) >> 2);
int32_t range = 1 << nBits; int32_t range = 1 << nBits;
if (result < range && result > -range) { if (result < range && result > -range) {
result = scatterBits(result, findv4bitmask(loc)); result = scatterBits(result, findv4bitmask(loc));
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
return 1;
} }
/// \brief Word32_LO: 0x00c03fff : (S + A) : Truncate /// \brief Word32_LO: 0x00c03fff : (S + A) : Truncate
static int relocLO16(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A) { static void relocLO16(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A) {
uint32_t result = (uint32_t)(S + A); uint32_t result = (uint32_t)(S + A);
result = scatterBits(result, 0x00c03fff); result = scatterBits(result, 0x00c03fff);
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
/// \brief Word32_LO: 0x00c03fff : (S + A) >> 16 : Truncate /// \brief Word32_LO: 0x00c03fff : (S + A) >> 16 : Truncate
static int relocHI16(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A) { static void relocHI16(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A) {
uint32_t result = (uint32_t)((S + A) >> 16); uint32_t result = (uint32_t)((S + A) >> 16);
result = scatterBits(result, 0x00c03fff); result = scatterBits(result, 0x00c03fff);
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
/// \brief Word32: 0xffffffff : (S + A) : Truncate /// \brief Word32: 0xffffffff : (S + A) : Truncate
static int reloc32(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A) { static void reloc32(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A) {
uint32_t result = (uint32_t)(S + A); uint32_t result = (uint32_t)(S + A);
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
static int reloc32_6_X(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A) { static void reloc32_6_X(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A) {
int64_t result = ((S + A) >> 6); int64_t result = ((S + A) >> 6);
int64_t range = ((int64_t)1) << 32; int64_t range = ((int64_t)1) << 32;
if (result > range) if (result > range)
return 1;
result = scatterBits(result, 0xfff3fff); result = scatterBits(result, 0xfff3fff);
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
// R_HEX_B32_PCREL_X // R_HEX_B32_PCREL_X
static int relocHexB32PCRELX(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A) { static void relocHexB32PCRELX(uint8_t *loc, uint64_t P, uint64_t S,
uint64_t A) {
int64_t result = ((S + A - P) >> 6); int64_t result = ((S + A - P) >> 6);
result = scatterBits(result, 0xfff3fff); result = scatterBits(result, 0xfff3fff);
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
// R_HEX_BN_PCREL_X // R_HEX_BN_PCREL_X
static int relocHexBNPCRELX(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A, static void relocHexBNPCRELX(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A,
int nbits) { int nbits) {
int32_t result = ((S + A - P) & 0x3f); int32_t result = ((S + A - P) & 0x3f);
int32_t range = 1 << nbits; int32_t range = 1 << nbits;
if (result < range && result > -range) { if (result < range && result > -range) {
result = scatterBits(result, findv4bitmask(loc)); result = scatterBits(result, findv4bitmask(loc));
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
return 1;
} }
// R_HEX_6_PCREL_X // R_HEX_6_PCREL_X
static int relocHex6PCRELX(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A) { static void relocHex6PCRELX(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A) {
int32_t result = (S + A - P); int32_t result = (S + A - P);
result = scatterBits(result, findv4bitmask(loc)); result = scatterBits(result, findv4bitmask(loc));
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
// R_HEX_N_X : Word32_U6 : (S + A) : Unsigned Truncate // R_HEX_N_X : Word32_U6 : (S + A) : Unsigned Truncate
static int relocHex_N_X(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A) { static void relocHex_N_X(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A) {
uint32_t result = (S + A); uint32_t result = (S + A);
result = scatterBits(result, findv4bitmask(loc)); result = scatterBits(result, findv4bitmask(loc));
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
// GP REL relocs // GP REL relocs
static int relocHexGPRELN(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A, static void relocHexGPRELN(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A,
uint64_t GP, int nShiftBits) { uint64_t GP, int nShiftBits) {
int32_t result = (int64_t)((S + A - GP) >> nShiftBits); int32_t result = (int64_t)((S + A - GP) >> nShiftBits);
int32_t range = 1L << 16; int32_t range = 1L << 16;
if (result <= range) { if (result <= range) {
result = scatterBits(result, findv4bitmask(loc)); result = scatterBits(result, findv4bitmask(loc));
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
return 1;
} }
/// \brief Word32_LO: 0x00c03fff : (G) : Truncate /// \brief Word32_LO: 0x00c03fff : (G) : Truncate
static int relocHexGOTLO16(uint8_t *loc, uint64_t A, uint64_t GOT) { static void relocHexGOTLO16(uint8_t *loc, uint64_t A, uint64_t GOT) {
int32_t result = (int32_t)(A-GOT); int32_t result = (int32_t)(A-GOT);
result = scatterBits(result, 0x00c03fff); result = scatterBits(result, 0x00c03fff);
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
/// \brief Word32_LO: 0x00c03fff : (G) >> 16 : Truncate /// \brief Word32_LO: 0x00c03fff : (G) >> 16 : Truncate
static int relocHexGOTHI16(uint8_t *loc, uint64_t A, uint64_t GOT) { static void relocHexGOTHI16(uint8_t *loc, uint64_t A, uint64_t GOT) {
int32_t result = (int32_t)((A-GOT) >> 16); int32_t result = (int32_t)((A-GOT) >> 16);
result = scatterBits(result, 0x00c03fff); result = scatterBits(result, 0x00c03fff);
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
/// \brief Word32: 0xffffffff : (G) : Truncate /// \brief Word32: 0xffffffff : (G) : Truncate
static int relocHexGOT32(uint8_t *loc, uint64_t A, uint64_t GOT) { static void relocHexGOT32(uint8_t *loc, uint64_t A, uint64_t GOT) {
int32_t result = (int32_t)(GOT - A); int32_t result = (int32_t)(GOT - A);
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
/// \brief Word32_U16 : (G) : Truncate /// \brief Word32_U16 : (G) : Truncate
static int relocHexGOT16(uint8_t *loc, uint64_t A, uint64_t GOT) { static void relocHexGOT16(uint8_t *loc, uint64_t A, uint64_t GOT) {
int32_t result = (int32_t)(GOT-A); int32_t result = (int32_t)(GOT-A);
int32_t range = 1L << 16; int32_t range = 1L << 16;
if (result <= range) { if (result <= range) {
result = scatterBits(result, findv4bitmask(loc)); result = scatterBits(result, findv4bitmask(loc));
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
return 1;
} }
static int relocHexGOT32_6_X(uint8_t *loc, uint64_t A, uint64_t GOT) { static void relocHexGOT32_6_X(uint8_t *loc, uint64_t A, uint64_t GOT) {
int32_t result = (int32_t)((A-GOT) >> 6); int32_t result = (int32_t)((A-GOT) >> 6);
result = scatterBits(result, findv4bitmask(loc)); result = scatterBits(result, findv4bitmask(loc));
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
static int relocHexGOT16_X(uint8_t *loc, uint64_t A, uint64_t GOT) { static void relocHexGOT16_X(uint8_t *loc, uint64_t A, uint64_t GOT) {
int32_t result = (int32_t)(A-GOT); int32_t result = (int32_t)(A-GOT);
int32_t range = 1L << 6; int32_t range = 1L << 6;
if (result <= range) { if (result <= range) {
result = scatterBits(result, findv4bitmask(loc)); result = scatterBits(result, findv4bitmask(loc));
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
return 1;
} }
static int relocHexGOT11_X(uint8_t *loc, uint64_t A, uint64_t GOT) { static void relocHexGOT11_X(uint8_t *loc, uint64_t A, uint64_t GOT) {
uint32_t result = (uint32_t)(A-GOT); uint32_t result = (uint32_t)(A-GOT);
result = scatterBits(result, findv4bitmask(loc)); result = scatterBits(result, findv4bitmask(loc));
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
static int relocHexGOTRELSigned(uint8_t *loc, uint64_t P, uint64_t S, static void relocHexGOTRELSigned(uint8_t *loc, uint64_t P, uint64_t S,
uint64_t A, uint64_t GOT, int shiftBits = 0) { uint64_t A, uint64_t GOT, int shiftBits = 0) {
int32_t result = (int32_t)((S + A - GOT) >> shiftBits); int32_t result = (int32_t)((S + A - GOT) >> shiftBits);
result = scatterBits(result, findv4bitmask(loc)); result = scatterBits(result, findv4bitmask(loc));
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
static int relocHexGOTRELUnsigned(uint8_t *loc, uint64_t P, uint64_t S, static void relocHexGOTRELUnsigned(uint8_t *loc, uint64_t P, uint64_t S,
uint64_t A, uint64_t GOT, int shiftBits = 0) { uint64_t A, uint64_t GOT,
int shiftBits = 0) {
uint32_t result = (uint32_t)((S + A - GOT) >> shiftBits); uint32_t result = (uint32_t)((S + A - GOT) >> shiftBits);
result = scatterBits(result, findv4bitmask(loc)); result = scatterBits(result, findv4bitmask(loc));
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
static int relocHexGOTREL_HILO16(uint8_t *loc, uint64_t P, uint64_t S, static void relocHexGOTREL_HILO16(uint8_t *loc, uint64_t P, uint64_t S,
uint64_t A, uint64_t GOT, int shiftBits = 0) { uint64_t A, uint64_t GOT, int shiftBits = 0) {
int32_t result = (int32_t)((S + A - GOT) >> shiftBits); int32_t result = (int32_t)((S + A - GOT) >> shiftBits);
result = scatterBits(result, 0x00c03fff); result = scatterBits(result, 0x00c03fff);
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
static int relocHexGOTREL_32(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A, static void relocHexGOTREL_32(uint8_t *loc, uint64_t P, uint64_t S, uint64_t A,
uint64_t GOT) { uint64_t GOT) {
int32_t result = (int32_t)(S + A - GOT); int32_t result = (int32_t)(S + A - GOT);
write32le(loc, result | read32le(loc)); write32le(loc, result | read32le(loc));
return 0;
} }
std::error_code HexagonTargetRelocationHandler::applyRelocation( std::error_code HexagonTargetRelocationHandler::applyRelocation(
ELFWriter &writer, llvm::FileOutputBuffer &buf, const lld::AtomLayout &atom, ELFWriter &writer, llvm::FileOutputBuffer &buf, const lld::AtomLayout &atom,
const Reference &ref) const { const Reference &ref) const {
uint8_t *atomContent = buf.getBufferStart() + atom._fileOffset; uint8_t *atomContent = buf.getBufferStart() + atom._fileOffset;
uint8_t *loc = atomContent + ref.offsetInAtom(); uint8_t *loc = atomContent + ref.offsetInAtom();
uint64_t target = writer.addressOfAtom(ref.target()); uint64_t target = writer.addressOfAtom(ref.target());
▲ Show 20 Lines • Show All 126 Lines • Show Last 20 Lines