This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Also Catch invalid calls to TestPExpectTest's expect()
ClosedPublic

Authored by teemperor on Oct 13 2020, 2:10 AM.

Details

Summary

This is a follow up to D88792 which found an issue in a call to PExpectTest's expect function
that allows passing a string to the substrs parameter. However this issue was found by just
grepping and TestPExpect's expect function is still accepting a single string as a value to substrs.

This patch adds the same sanity check that D88792 added to the PExpectTest's implementation
of expect and also adds a small test for it.

Diff Detail

Event Timeline

teemperor created this revision.Oct 13 2020, 2:10 AM
teemperor requested review of this revision.Oct 13 2020, 2:10 AM
kastiglione accepted this revision.Oct 19 2020, 9:58 AM
This revision is now accepted and ready to land.Oct 19 2020, 9:58 AM
JDevlieghere accepted this revision.Oct 19 2020, 12:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 5 2020, 5:09 AM