This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Don't let dotest silently fall back to default SDK if the specified one can't be found
ClosedPublic

Authored by teemperor on Oct 8 2020, 9:17 AM.

Details

Summary

If the SDK name passed to dotest can't be found by xcrun we silently fall back to the default SDK.
This leads to rather cryptic errors being reported later on when linking the actual test executables.

Instead just directly log and abort when this situation is encountered and inform the user about
the invalid argument.

Diff Detail

Event Timeline

teemperor requested review of this revision.Oct 8 2020, 9:17 AM
teemperor created this revision.
JDevlieghere accepted this revision.Oct 8 2020, 10:07 AM
This revision is now accepted and ready to land.Oct 8 2020, 10:07 AM
teemperor added a project: Restricted Project.Oct 12 2020, 10:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2020, 6:08 AM