[lldb] Don't add no-sandbox entitlement when running tests on simulator

[teemperor]

Summary

It seems that if codesigning the test executables with the com.apple.private.security.no-sandbox entitlement
then the simulator refuses to launch them and every test fails with Process launch failed: process exited with status -1 (no such process.).

This patch checks if we're trying to run the test suite on the simulator and then avoids signing the executable
with no-sandbox.

[JDevlieghere]

lldb/packages/Python/lldbsuite/test/builders/darwin.py

75

Maybe entitlements_file = 'entitlements-simulator.plist' if env == "simulator" else 'entitlements.plist' if it fits in 120 cols

lldb/packages/Python/lldbsuite/test/builders/darwin.py

def getExtraMakeArgs(self):
         Helper function to return extra argumentsfor the make system. This
         method is meant to be overridden by platform specific builders.
         """
         args = dict()
 
         if configuration.dsymutil:
             args['DSYMUTIL'] = configuration.dsymutil
 
-        operating_system, _ = get_os_and_env()
+        operating_system, env = get_os_and_env()
         if operating_system and operating_system != "macosx":
             builder_dir = os.path.dirname(os.path.abspath(__file__))
             test_dir = os.path.dirname(builder_dir)
-            entitlements = os.path.join(test_dir, 'make', 'entitlements.plist')
+            if env == "simulator":
+              entitlements_file = 'entitlements-simulator.plist'
+            else:
+              entitlements_file = 'entitlements.plist'
+            entitlements = os.path.join(test_dir, 'make', entitlements_file)
             args['CODESIGN'] = 'codesign --entitlements {}'.format(
                 entitlements)
 
         # Return extra args as a formatted string.
         return ' '.join(
             {'{}="{}"'.format(key, value)
              for key, value in args.items()})
 

lldb/packages/Python/lldbsuite/test/make/entitlements-simulator.plist

+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+    <key>com.apple.security.get-task-allow</key>
+    <true/>
+</dict>
+</plist>