This is an archive of the discontinued LLVM Phabricator instance.

[TableGen] AsmMatcher: fix OpIdx of tied operands when HasOptionalOperands is true
Needs ReviewPublic

Authored by TOCK on Sep 28 2020, 3:33 AM.

Details

Reviewers
arsenm
Summary

For tied operands, entry in ConversionTable does not store operand
index but the index of TiedAsmOperandTable where the actual operand
index comes from. Only subtract the number of optional operands after
actual operand index is known or it would use wrong entry from
TiedAsmOperandTable and tied to wrong operand as a result.

Diff Detail

Event Timeline

TOCK created this revision.Sep 28 2020, 3:33 AM
TOCK requested review of this revision.Sep 28 2020, 3:33 AM
TOCK updated this revision to Diff 308254.Nov 29 2020, 7:35 PM

Include full context.