This is an archive of the discontinued LLVM Phabricator instance.

[libc] Using llvm_libc memcpy in mem* benchmarks.
ClosedPublic

Authored by asteinhauser on Sep 24 2020, 5:11 PM.

Details

Summary

Currently the mem* benchmarks use memcpy from Glibc and memset from LLVM libc.
That's misleading and produces inconsistent results and behaviors.

This change makes Memcpy.cpp consistent with Memset.cpp:
https://github.com/llvm/llvm-project/blob/master/libc/benchmarks/Memset.cpp#L49

Diff Detail

Event Timeline

asteinhauser created this revision.Sep 24 2020, 5:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 24 2020, 5:11 PM
asteinhauser requested review of this revision.Sep 24 2020, 5:11 PM
sivachandra accepted this revision.Sep 24 2020, 8:38 PM

Ah, thanks for catching this. I seem to have missed this in https://reviews.llvm.org/D81910.

This revision is now accepted and ready to land.Sep 24 2020, 8:38 PM
This revision was landed with ongoing or failed builds.Sep 24 2020, 10:04 PM
This revision was automatically updated to reflect the committed changes.