This is an archive of the discontinued LLVM Phabricator instance.

Thanks Mehdi! Could you or someone else help me to commit it? I am still in the process of creating patches before requesting my commit access. Thanks again!

This revision was landed with ongoing or failed builds.Sep 22 2020, 4:40 PM

Closed by commit rGaf429cd89bf8: [NFC][docs] Fix link. (authored by antonio-cortes-perez, committed by mehdi_amini). · Explain Why

This revision was automatically updated to reflect the committed changes.

mehdi_amini added a commit: rGaf429cd89bf8: [NFC][docs] Fix link..

Revision Contents

Path

Size

llvm/

docs/

GettingStarted.rst

3 lines

Phabricator.rst

2 lines

Diff 293565

llvm/docs/GettingStarted.rst

Show First 20 Lines • Show All 522 Lines • ▼ Show 20 Lines	.. code-block:: console
% git push origin HEAD:master		% git push origin HEAD:master

LLVM currently has a linear-history policy, which means that merge commits are		LLVM currently has a linear-history policy, which means that merge commits are
not allowed. The `llvm-project` repo on github is configured to reject pushes		not allowed. The `llvm-project` repo on github is configured to reject pushes
that include merges, so the `git rebase` step above is required.		that include merges, so the `git rebase` step above is required.

Please ask for help if you're having trouble with your particular git workflow.		Please ask for help if you're having trouble with your particular git workflow.


		.. _git_pre_push_hook:

Git pre-push hook		Git pre-push hook
^^^^^^^^^^^^^^^^^		^^^^^^^^^^^^^^^^^

We include an optional pre-push hook that run some sanity checks on the revisions		We include an optional pre-push hook that run some sanity checks on the revisions
you are about to push and ask confirmation if you push multiple commits at once.		you are about to push and ask confirmation if you push multiple commits at once.
You can set it up (on Unix systems) by running from the repository root:		You can set it up (on Unix systems) by running from the repository root:

.. code-block:: console		.. code-block:: console
▲ Show 20 Lines • Show All 677 Lines • Show Last 20 Lines

llvm/docs/Phabricator.rst

	Show First 20 Lines • Show All 181 Lines • ▼ Show 20 Lines
	the git revision number in the Comment, set the Action to "Close Revision" and			the git revision number in the Comment, set the Action to "Close Revision" and
	click Submit. Note the review must have been Accepted first.			click Submit. Note the review must have been Accepted first.

	Arcanist also adds extra tags that are mostly noise in the commit message, for			Arcanist also adds extra tags that are mostly noise in the commit message, for
	this reason avoid using `arc land` and push commits to master directly with git			this reason avoid using `arc land` and push commits to master directly with git
	after removing tags other than "Reviewed by" and "Differential Revision".			after removing tags other than "Reviewed by" and "Differential Revision".
	You can run `llvm/utils/git/arcfilter.sh` to clean the commit message of the			You can run `llvm/utils/git/arcfilter.sh` to clean the commit message of the
	current "HEAD" commit automatically. You can also setup a git hook to catch this			current "HEAD" commit automatically. You can also setup a git hook to catch this
	for you (see `Getting Started <GettingStarted.html#git-pre-push-hook>`).			for you (see :ref:`git_pre_push_hook`).


	Committing someone's change from Phabricator			Committing someone's change from Phabricator
	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^			^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

	On a clean Git repository on an up to date ``master`` branch run the			On a clean Git repository on an up to date ``master`` branch run the
	following (where ``<Revision>`` is the Phabricator review number):			following (where ``<Revision>`` is the Phabricator review number):

	▲ Show 20 Lines • Show All 58 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[NFC][docs] Fix link.ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 293565

llvm/docs/GettingStarted.rst

llvm/docs/Phabricator.rst

[NFC][docs] Fix link.
ClosedPublic