This is an archive of the discontinued LLVM Phabricator instance.

Differential D88061

[Testsuite] allow a linker to be specified
ClosedPublic

Authored by davide on Sep 21 2020, 5:57 PM.

Details

Reviewers
cmatthews

Diff Detail

Event Timeline

davide created this revision.Sep 21 2020, 5:57 PM
Herald added a subscriber: mgorny. · View Herald TranscriptSep 21 2020, 5:57 PM
davide requested review of this revision.Sep 21 2020, 5:57 PM
cmatthews accepted this revision.Sep 21 2020, 6:04 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Sep 21 2020, 6:04 PM
davide added a comment.Sep 21 2020, 6:06 PM

Committed thusly

commit f95eba922b0a1b07e2c68734c9cc7d6c1754d744 (HEAD -> master, origin/master, origin/HEAD)
Author: Davide Italiano <ditaliano@apple.com>
Date:   Mon Sep 21 18:05:55 2020 -0700

    [testsuite] Allow a (custom) linker to be specified.
    
    Differential Revision:  https://reviews.llvm.org/D88061
davide closed this revision.Sep 21 2020, 6:06 PM

Revision Contents

PathSize
11 lines

Diff 293305

CMakeLists.txt

Context not available.
project(test-suite C CXX) project(test-suite C CXX)
function(append value)
foreach(variable ${ARGN})
set(${variable} "${${variable}} ${value}" PARENT_SCOPE)
endforeach(variable)
endfunction()
# The test-suite is designed to be built in release mode anyway and # The test-suite is designed to be built in release mode anyway and
# falls over unless -DNDEBUG is set. # falls over unless -DNDEBUG is set.
if(NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES) if(NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)
Context not available.
set(CMAKE_EXE_LINKER_FLAGS set(CMAKE_EXE_LINKER_FLAGS
"${CMAKE_EXE_LINKER_FLAGS} ${TEST_SUITE_DIAGNOSE_LINKER_FLAGS}") "${CMAKE_EXE_LINKER_FLAGS} ${TEST_SUITE_DIAGNOSE_LINKER_FLAGS}")
if (TESTSUITE_USE_LINKER)
append("-fuse-ld=${TESTSUITE_USE_LINKER}"
CMAKE_EXE_LINKER_FLAGS CMAKE_MODULE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAG)
endif()
# Append extra flags. These extra flags are mainly meant for cache files that # Append extra flags. These extra flags are mainly meant for cache files that
# want to apply flags that get not override even when the user manually # want to apply flags that get not override even when the user manually
# specifies CMAKE_C_FLAGS and similar. # specifies CMAKE_C_FLAGS and similar.
Context not available.