[lldb] Use GetNonKVOClassDescriptor to get the NSDictionary class descriptor

[JDevlieghere]

Summary

On macOS Big Sur the class descriptor contains the NSKVONotifying_ prefix. This is covered by TestDataFormatterObjCKVO.

[JDevlieghere]

Remove spurious change

[jingham]

LGTM. The KVO decorated class name is almost never useful, and certainly not here...

lldb/source/Plugins/Language/ObjC/NSDictionary.cpp

if (!process_sp)
     return false;
 
   ObjCLanguageRuntime *runtime = ObjCLanguageRuntime::Get(*process_sp);
 
   if (!runtime)
     return false;
 
   ObjCLanguageRuntime::ClassDescriptorSP descriptor(
-      runtime->GetClassDescriptor(valobj));
+      runtime->GetNonKVOClassDescriptor(valobj));
 
   if (!descriptor || !descriptor->IsValid())
     return false;
 
   uint32_t ptr_size = process_sp->GetAddressByteSize();
   bool is_64bit = (ptr_size == 8);
 
   lldb::addr_t valobj_addr = valobj.GetValueAsUnsigned(0);
 
   if (!valobj_addr)
     return false;
 
   uint64_t value = 0;
 
-  ConstString class_name(descriptor->GetClassName());
+  ConstString class_name = descriptor->GetClassName();
 
   static const ConstString g_DictionaryI("__NSDictionaryI");
   static const ConstString g_DictionaryM("__NSDictionaryM");
   static const ConstString g_DictionaryMLegacy("__NSDictionaryM_Legacy");
   static const ConstString g_DictionaryMImmutable("__NSDictionaryM_Immutable");
   static const ConstString g_Dictionary1("__NSSingleEntryDictionaryI");
   static const ConstString g_Dictionary0("__NSDictionary0");
   static const ConstString g_DictionaryCF("__CFDictionary");