Page MenuHomePhabricator

Do not construct string from nullptr
ClosedPublic

Authored by georgthegreat on Sep 5 2020, 3:13 AM.

Details

Summary

While I am trying to forbid such usages systematically in https://reviews.llvm.org/D79427 / P2166R0 to C++ standard, this PR fixes this (definitelly incorrect) usage in llvm.

Diff Detail

Event Timeline

georgthegreat created this revision.Sep 5 2020, 3:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2020, 3:13 AM
georgthegreat requested review of this revision.Sep 5 2020, 3:13 AM
georgthegreat edited the summary of this revision. (Show Details)
georgthegreat edited the summary of this revision. (Show Details)Sep 5 2020, 3:57 AM
georgthegreat edited the summary of this revision. (Show Details)Sep 5 2020, 7:55 AM
nikic accepted this revision.Sep 6 2020, 1:29 PM

(Marking as accepted per above.)

This revision is now accepted and ready to land.Sep 6 2020, 1:29 PM
georgthegreat accepted this revision.Sep 6 2020, 2:24 PM

I have no commit access to llvm monorepo, so could, please, someone land this commit?

This revision was automatically updated to reflect the committed changes.