This is an archive of the discontinued LLVM Phabricator instance.

Differential D8621

[DWARF] Remove an unused arg to SymbolFileDWARF::ParseChildParameters.
ClosedPublic

Authored by sivachandra on Mar 25 2015, 4:22 PM.

Details

Reviewers
clayborg
Commits
rG71e080646ea7: [DWARF] Remove an unused arg to SymbolFileDWARF::ParseChildParameters.
rLLDB233230: [DWARF] Remove an unused arg to SymbolFileDWARF::ParseChildParameters.
rL233230: [DWARF] Remove an unused arg to SymbolFileDWARF::ParseChildParameters.

Diff Detail

Event Timeline

sivachandra updated this revision to Diff 22686.Mar 25 2015, 4:22 PM
sivachandra retitled this revision from to [DWARF] Remove an unused arg to SymbolFileDWARF::ParseChildParameters..
sivachandra updated this object.
sivachandra edited the test plan for this revision. (Show Details)
sivachandra added a reviewer: clayborg.
sivachandra added a subscriber: Unknown Object (MLST).
sivachandra added a comment.Mar 25 2015, 4:24 PM

I will commit this as obvious.

Closed by commit rL233230: [DWARF] Remove an unused arg to SymbolFileDWARF::ParseChildParameters. (authored by sivachandra). · Explain WhyMar 25 2015, 4:26 PM
This revision was automatically updated to reflect the committed changes.
clayborg edited edge metadata.Mar 25 2015, 4:29 PM

Looks good.

Revision Contents

PathSize
source/
Plugins/
SymbolFile/
DWARF/
1 line
2 lines

Diff 22686

source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h

Show First 20 Lines • Show All 353 Lines • ▼ Show 20 Linesprotected:
size_t ParseChildParameters( size_t ParseChildParameters(
const lldb_private::SymbolContext& sc, const lldb_private::SymbolContext& sc,
clang::DeclContext *containing_decl_ctx, clang::DeclContext *containing_decl_ctx,
DWARFCompileUnit* dwarf_cu, DWARFCompileUnit* dwarf_cu,
const DWARFDebugInfoEntry *parent_die, const DWARFDebugInfoEntry *parent_die,
bool skip_artificial, bool skip_artificial,
bool &is_static, bool &is_static,
bool &is_variadic, bool &is_variadic,
lldb_private::TypeList* type_list,
std::vector<lldb_private::ClangASTType>& function_args, std::vector<lldb_private::ClangASTType>& function_args,
std::vector<clang::ParmVarDecl*>& function_param_decls, std::vector<clang::ParmVarDecl*>& function_param_decls,
unsigned &type_quals); unsigned &type_quals);
// lldb_private::ClangASTContext::TemplateParameterInfos &template_param_infos); // not currently needed // lldb_private::ClangASTContext::TemplateParameterInfos &template_param_infos); // not currently needed
size_t ParseChildEnumerators( size_t ParseChildEnumerators(
const lldb_private::SymbolContext& sc, const lldb_private::SymbolContext& sc,
▲ Show 20 Lines • Show All 255 Lines • Show Last 20 Lines

source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 4,297 Lines • ▼ Show 20 Lines
size_t size_t
SymbolFileDWARF::ParseChildParameters (const SymbolContext& sc, SymbolFileDWARF::ParseChildParameters (const SymbolContext& sc,
clang::DeclContext *containing_decl_ctx, clang::DeclContext *containing_decl_ctx,
DWARFCompileUnit* dwarf_cu, DWARFCompileUnit* dwarf_cu,
const DWARFDebugInfoEntry *parent_die, const DWARFDebugInfoEntry *parent_die,
bool skip_artificial, bool skip_artificial,
bool &is_static, bool &is_static,
bool &is_variadic, bool &is_variadic,
TypeList* type_list,
std::vector<ClangASTType>& function_param_types, std::vector<ClangASTType>& function_param_types,
std::vector<clang::ParmVarDecl*>& function_param_decls, std::vector<clang::ParmVarDecl*>& function_param_decls,
unsigned &type_quals) // , unsigned &type_quals) // ,
// ClangASTContext::TemplateParameterInfos &template_param_infos)) // ClangASTContext::TemplateParameterInfos &template_param_infos))
{ {
if (parent_die == NULL) if (parent_die == NULL)
return 0; return 0;
▲ Show 20 Lines • Show All 2,209 Lines • ▼ Show 20 Lines// }
bool skip_artificial = true; bool skip_artificial = true;
ParseChildParameters (sc, ParseChildParameters (sc,
containing_decl_ctx, containing_decl_ctx,
dwarf_cu, dwarf_cu,
die, die,
skip_artificial, skip_artificial,
is_static, is_static,
is_variadic, is_variadic,
type_list,
function_param_types, function_param_types,
function_param_decls, function_param_decls,
type_quals); type_quals);
} }
// clang_type will get the function prototype clang type after this call // clang_type will get the function prototype clang type after this call
clang_type = ast.CreateFunctionType (return_clang_type, clang_type = ast.CreateFunctionType (return_clang_type,
function_param_types.data(), function_param_types.data(),
▲ Show 20 Lines • Show All 1,471 Lines • Show Last 20 Lines