Page MenuHomePhabricator

[lldb] Fix that log enable's -f parameter causes LLDB to crash when it can't open the log file
ClosedPublic

Authored by teemperor on Aug 14 2020, 6:17 AM.

Details

Summary

We didn't do anything with the llvm::Error we get from Open, so when we end up in the
error case we just crash due to the llvm::Error sanity check. Also add the missing newline
behind the error message so it no longer messes with the next (lldb) prompt.

Diff Detail

Event Timeline

teemperor requested review of this revision.Aug 14 2020, 6:17 AM
teemperor created this revision.
JDevlieghere accepted this revision.Aug 14 2020, 12:37 PM
This revision is now accepted and ready to land.Aug 14 2020, 12:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2020, 1:43 AM
max-kudr added a subscriber: max-kudr.EditedAug 17 2020, 10:36 AM

@teemperor LLDB Windows buildbot is failing after last commit: Build 18298.

Please revert or fix.

@teemperor LLDB Windows buildbot is failing after last commit: Build 18298.

Please revert or fix.

Already fixed in c6cc566c8a95bb39c65f7b39649e804809fc8701, next build should be green again.