This is an archive of the discontinued LLVM Phabricator instance.

Differential D85953

[libc] Make mem* benchmark boxplots transparent.
ClosedPublic

Authored by asteinhauser on Aug 13 2020, 7:46 PM.

Details

Reviewers
sivachandra
Commits
rG25d759c143ce: [libc] Make benchmark boxplots transparent.
Summary

So that the configuration box does not make a part of the plot invisible.

Old plot:


New plot:

Diff Detail

Event Timeline

asteinhauser created this revision.Aug 13 2020, 7:46 PM
Herald added subscribers: ecnelises, tschuett. · View Herald TranscriptAug 13 2020, 7:46 PM
asteinhauser requested review of this revision.Aug 13 2020, 7:46 PM
asteinhauser edited the summary of this revision. (Show Details)Aug 16 2020, 2:10 PM
sivachandra accepted this revision.Aug 17 2020, 6:01 AM
This revision is now accepted and ready to land.Aug 17 2020, 6:01 AM
Closed by commit rG25d759c143ce: [libc] Make benchmark boxplots transparent. (authored by asteinhauser). · Explain WhyAug 17 2020, 7:34 AM
This revision was automatically updated to reflect the committed changes.
asteinhauser added a commit: rG25d759c143ce: [libc] Make benchmark boxplots transparent..
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2020, 7:34 AM
Herald added a subscriber: libc-commits. · View Herald Transcript

Revision Contents

PathSize
libc/
benchmarks/
2 lines

Diff 286020

libc/benchmarks/render.py3

Show First 20 Lines • Show All 143 Lines • ▼ Show 20 Lines if config:
plt.figtext( plt.figtext(
0.95, 0.95,
0.15, 0.15,
pprint.pformat(config), pprint.pformat(config),
verticalalignment="bottom", verticalalignment="bottom",
horizontalalignment="right", horizontalalignment="right",
multialignment="left", multialignment="left",
fontsize="small", fontsize="small",
bbox=dict(boxstyle="round", facecolor="wheat")) bbox=dict(boxstyle="round", facecolor="wheat", alpha=0.5))
axes = plt.gca() axes = plt.gca()
axes.set_title(get_title(get_host(jsons))) axes.set_title(get_title(get_host(jsons)))
axes.set_ylim(bottom=0) axes.set_ylim(bottom=0)
axes.set_xlabel("Size") axes.set_xlabel("Size")
axes.xaxis.set_major_formatter(EngFormatter(unit="B")) axes.xaxis.set_major_formatter(EngFormatter(unit="B"))
if display == "cycles": if display == "cycles":
axes.set_ylabel("Cycles") axes.set_ylabel("Cycles")
Show All 34 Lines