This is an archive of the discontinued LLVM Phabricator instance.

Differential D85266

Include math header early to avoid HUGE_VALF redefinition
AbandonedPublic

Authored by jpark37 on Aug 4 2020, 6:27 PM.

Details

Reviewers
deadalnix
Summary

Fix math.h warning if included after DataTypes.h header.

Diff Detail

Event Timeline

jpark37 created this revision.Aug 4 2020, 6:27 PM
Herald added a reviewer: deadalnix. · View Herald TranscriptAug 4 2020, 6:27 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: llvm-commits. · View Herald Transcript
jpark37 requested review of this revision.Aug 4 2020, 6:27 PM
Harbormaster completed remote builds in B67031: Diff 283093.Aug 4 2020, 7:45 PM
jpark37 abandoned this revision.Nov 27 2020, 5:43 PM

Looks like the issue was fixed by 9124fa592098d3794d7b31f83a58e40cc469ff0c.

Revision Contents

PathSize
llvm/
include/
llvm-c/
2 lines

Diff 283093

llvm/include/llvm-c/DataTypes.h

Show First 20 Lines • Show All 44 Lines • ▼ Show 20 Lines
#ifdef _AIX #ifdef _AIX
// GCC is strict about defining large constants: they must have LL modifier. // GCC is strict about defining large constants: they must have LL modifier.
#undef INT64_MAX #undef INT64_MAX
#undef INT64_MIN #undef INT64_MIN
#endif #endif
#else /* _MSC_VER */ #else /* _MSC_VER */
#ifdef __cplusplus #ifdef __cplusplus
#include <cmath>
#include <cstddef> #include <cstddef>
#include <cstdlib> #include <cstdlib>
#else #else
#include <math.h>
#include <stddef.h> #include <stddef.h>
#include <stdlib.h> #include <stdlib.h>
#endif #endif
#include <sys/types.h> #include <sys/types.h>
#if defined(_WIN64) #if defined(_WIN64)
typedef signed __int64 ssize_t; typedef signed __int64 ssize_t;
#else #else
Show All 21 Lines