This is an archive of the discontinued LLVM Phabricator instance.

Differential D8514

s/teh/the and other grammos
ClosedPublic

Authored by eax on Mar 21 2015, 11:42 PM.

Download Raw Diff

Details

Reviewers

mkuper
davide

Commits

rG8ed40ce56d0f: Correct 'teh' and other typos / repeated words.
rL234939: Correct 'teh' and other typos / repeated words.

Summary

all those words make teh duplicate duplicate words and other mistakes hard to find

Diff Detail

Event Timeline

eax updated this revision to Diff 22416.Mar 21 2015, 11:42 PM

eax retitled this revision from to s/teh/the.

eax updated this object.

eax edited the test plan for this revision. (Show Details)

eax added a reviewer: davide.

eax added a subscriber: Unknown Object (MLST).Mar 21 2015, 11:45 PM

include a variety of other grammos as well

eax retitled this revision from s/teh/the to s/teh/the and other grammos.Mar 22 2015, 1:26 AM

eax updated this object.

Thanks! :)
A couple of minor comments.

docs/ProgrammersManual.rst
943 ↗	(On Diff #22417)	I think this should have been "it is".
docs/tutorial/LangImpl7.rst
635 ↗	(On Diff #22417)	As long as we're fixing grammar here, shouldn't it be "other extension"?

Per mkuper

eax added a reviewer: mkuper.Mar 22 2015, 1:17 PM

LGTM

This revision is now accepted and ready to land.Mar 23 2015, 1:02 AM

Do you need me to commit this for you?

Closed by commit rL234939: Correct 'teh' and other typos / repeated words. (authored by emaste). · Explain WhyApr 14 2015, 1:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

include/

llvm/

Support/

2 lines

lib/

Target/

PowerPC/

README_ALTIVEC.txt

2 lines

Diff 22416

include/llvm/Support/Options.h

	Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines

	} // namespace detail			} // namespace detail

	/// \brief Singleton class used to register debug options.			/// \brief Singleton class used to register debug options.
	///			///
	/// The OptionRegistry is responsible for managing lifetimes of the options and			/// The OptionRegistry is responsible for managing lifetimes of the options and
	/// provides interfaces for option registration and reading values from options.			/// provides interfaces for option registration and reading values from options.
	/// This object is a singleton, only one instance should ever exist so that all			/// This object is a singleton, only one instance should ever exist so that all
	/// options are registered in teh same place.			/// options are registered in the same place.
	class OptionRegistry {			class OptionRegistry {
	private:			private:
	DenseMap<void , cl::Option > Options;			DenseMap<void , cl::Option > Options;

	/// \brief Adds a cl::Option to the registry.			/// \brief Adds a cl::Option to the registry.
	///			///
	/// \param Key unique key for option			/// \param Key unique key for option
	/// \param O option to map to \p Key			/// \param O option to map to \p Key
	▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines

lib/Target/PowerPC/README_ALTIVEC.txt

	Show First 20 Lines • Show All 271 Lines • ▼ Show 20 Lines		This will generate the following instruction sequence:
	ori 2, 2, 0			ori 2, 2, 0
	lxvd2x 35, 0, 3			lxvd2x 35, 0, 3
	vaddudm 2, 2, 3			vaddudm 2, 2, 3
	blr			blr

	This will almost certainly cause a load-hit-store hazard.			This will almost certainly cause a load-hit-store hazard.
	Since val is a value parameter, it should not need to be saved onto			Since val is a value parameter, it should not need to be saved onto
	the stack, unless it's being done set up the vector register. Instead,			the stack, unless it's being done set up the vector register. Instead,
	it would be better to splat teh value into a vector register, and then			it would be better to splat the value into a vector register, and then
	remove the (dead) stores to the stack.			remove the (dead) stores to the stack.

	//===----------------------------------------------------------------------===//			//===----------------------------------------------------------------------===//

	At the moment we always generate a lxsdx in preference to lfd, or stxsdx in			At the moment we always generate a lxsdx in preference to lfd, or stxsdx in
	preference to stfd. When we have a reg-immediate addressing mode, this is a			preference to stfd. When we have a reg-immediate addressing mode, this is a
	poor choice, since we have to load the address into an index register. This			poor choice, since we have to load the address into an index register. This
	should be fixed for P7/P8.			should be fixed for P7/P8.
	Show All 27 Lines