This is an archive of the discontinued LLVM Phabricator instance.

Differential D84859

Disable getauxval for Go
ClosedPublic

Authored by randall77 on Jul 29 2020, 8:49 AM.

Details

Reviewers
dvyukov
vitalybuka
Commits
rG6c75db8b4bc5: Disable getauxval for Go
Summary

We want the Go build to not use getauxval, as we must support glibc < 2.16 platforms.

Diff Detail

Event Timeline

randall77 created this revision.Jul 29 2020, 8:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2020, 8:49 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
randall77 requested review of this revision.Jul 29 2020, 8:49 AM
Harbormaster completed remote builds in B66225: Diff 281621.Jul 29 2020, 9:28 AM
dvyukov added a reviewer: vitalybuka.Jul 30 2020, 1:45 AM
randall77 updated this revision to Diff 281967.Jul 30 2020, 10:05 AM

Formatting changes

dvyukov accepted this revision.Jul 30 2020, 12:15 PM
This revision is now accepted and ready to land.Jul 30 2020, 12:15 PM
randall77 updated this revision to Diff 282253.Jul 31 2020, 10:02 AM

Add linewrap backslash

Closed by commit rG6c75db8b4bc5: Disable getauxval for Go (authored by randall77). · Explain WhyJul 31 2020, 10:13 AM
This revision was automatically updated to reflect the committed changes.
randall77 added a commit: rG6c75db8b4bc5: Disable getauxval for Go.

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
5 lines

Diff 282257

compiler-rt/lib/sanitizer_common/sanitizer_getauxval.h

Show All 15 Lines
#ifndef SANITIZER_GETAUXVAL_H #ifndef SANITIZER_GETAUXVAL_H
#define SANITIZER_GETAUXVAL_H #define SANITIZER_GETAUXVAL_H
#include "sanitizer_platform.h" #include "sanitizer_platform.h"
#include "sanitizer_glibc_version.h" #include "sanitizer_glibc_version.h"
#if SANITIZER_LINUX || SANITIZER_FUCHSIA #if SANITIZER_LINUX || SANITIZER_FUCHSIA
# if __GLIBC_PREREQ(2, 16) || (SANITIZER_ANDROID && __ANDROID_API__ >= 21) || \ # if (__GLIBC_PREREQ(2, 16) || (SANITIZER_ANDROID && __ANDROID_API__ >= 21) || \
SANITIZER_FUCHSIA SANITIZER_FUCHSIA) && \
!SANITIZER_GO
# define SANITIZER_USE_GETAUXVAL 1 # define SANITIZER_USE_GETAUXVAL 1
# else # else
# define SANITIZER_USE_GETAUXVAL 0 # define SANITIZER_USE_GETAUXVAL 0
# endif # endif
# if SANITIZER_USE_GETAUXVAL # if SANITIZER_USE_GETAUXVAL
# include <sys/auxv.h> # include <sys/auxv.h>
# else # else
Show All 26 Lines