Page MenuHomePhabricator

[HIP] Emit target-id module flag
AcceptedPublic

Authored by yaxunl on Jul 28 2020, 9:42 PM.

Details

Reviewers
tra
Summary

Separate this patch from https://reviews.llvm.org/D60620 since it depends on https://reviews.llvm.org/D80750

Diff Detail

Event Timeline

yaxunl requested review of this revision.Jul 28 2020, 9:42 PM
yaxunl created this revision.
tra accepted this revision.Jul 29 2020, 11:27 AM
tra added inline comments.
clang/lib/CodeGen/CodeGenModule.cpp
603–605

Make it a TargetIdStr initializer and just pass TargetIdStr instead?

clang/test/CodeGenCXX/conditional-temporaries.cpp
67–68

This looks like an unrelated change.

This revision is now accepted and ready to land.Jul 29 2020, 11:27 AM