[mips] [IAS] Rename getATRegNum and setATReg to {g,s}etATRegIndex. NFC.

[dsanders]

I agree with the principle that the set/get functions should have the same names. I think we ought to make it clear that it's an index though. Maybe, [gs]etATRegIndex()?

lib/Target/Mips/AsmParser/MipsAsmParser.cpp

2212

Are you going to eliminate the casts in a follow up?

[tomatabacu]

Replied to an inline comment.

lib/Target/Mips/AsmParser/MipsAsmParser.cpp

2212

D8479 takes care of those casts.

[tomatabacu]

Renamed getATRegNum to getATRegIndex instead of getATReg.
Also renamed setATReg to setATRegIndex.

[tomatabacu]

Ping.

[tomatabacu]

Ping.

[dsanders]

LGTM

lib/Target/Mips/AsmParser/MipsAsmParser.cpp

 
 namespace {
 class MipsAssemblerOptions {
 public:
   MipsAssemblerOptions(uint64_t Features_) : 
     ATReg(1), Reorder(true), Macro(true), Features(Features_) {}
 
   MipsAssemblerOptions(const MipsAssemblerOptions *Opts) {
-    ATReg = Opts->getATRegNum();
+    ATReg = Opts->getATReg();
     Reorder = Opts->isReorder();
     Macro = Opts->isMacro();
     Features = Opts->getFeatures();
   }
 
-  unsigned getATRegNum() const { return ATReg; }
+  unsigned getATReg() const { return ATReg; }
   bool setATReg(unsigned Reg);
 
   bool isReorder() const { return Reorder; }
   void setReorder() { Reorder = true; }
   void setNoReorder() { Reorder = false; }
 
   bool isMacro() const { return Macro; }
   void setMacro() { Macro = true; }
void MipsAsmParser::expandMemInst(MCInst &Inst, SMLoc IDLoc,
   if (isLoad && IsGPR && (BaseRegNum != RegOpNum))
     TmpRegNum = RegOpNum;
   else {
     // At this point we need AT to perform the expansions.
     // If it is not available, an error is given and then we exit.
     if (!isATAvailable(IDLoc))
       return;
 
-    unsigned AT = AssemblerOptions.back()->getATRegNum();
+    unsigned AT = AssemblerOptions.back()->getATReg();
     TmpRegNum = getReg(
         (isGP64bit()) ? Mips::GPR64RegClassID : Mips::GPR32RegClassID, AT);
   }
 
   TempInst.setOpcode(Mips::LUi);
   TempInst.addOperand(MCOperand::CreateReg(TmpRegNum));
   if (isImmOpnd)
     TempInst.addOperand(MCOperand::CreateImm(HiOffset));
case Match_RequiresDifferentSrcAndDst:
     return Error(IDLoc, "source and destination must be different");
   }
 
   llvm_unreachable("Implement any new match types added!");
 }
 
 bool MipsAsmParser::isATAvailable(SMLoc IDLoc) {
   // If AT is not available, give an error.
-  if (AssemblerOptions.back()->getATRegNum() == 0) {
+  if (AssemblerOptions.back()->getATReg() == 0) {
     reportParseError(
         IDLoc, "pseudo-instruction requires $at, which is not available");
     return false;
   }
   return true;
 }
 
 void MipsAsmParser::warnIfAssemblerTemporary(int RegIndex, SMLoc Loc) {
   if ((RegIndex != 0) && 
-      ((int)AssemblerOptions.back()->getATRegNum() == RegIndex)) {
+      ((int)AssemblerOptions.back()->getATReg() == RegIndex)) {
     if (RegIndex == 1)
       Warning(Loc, "used $at without \".set noat\"");
     else
       Warning(Loc, Twine("used $") + Twine(RegIndex) + " with \".set at=$" +
                        Twine(RegIndex) + "\"");
   }
 }