Remove IDE_MI_APP_EXIT_OK msg on exit (MI)

[ki.stfu]

Summary

Remove IDE_MI_APP_EXIT_OK msg on exit (MI)

[ki.stfu]

Hello @abidh,

How you think, should we keep a logging on exit?

tools/lldb-mi/MIDriverMgr.cpp

114–133

or I should remove all these lines?

[abidh]

tools/lldb-mi/MIDriverMgr.cpp

114–133

vbAppExitOk will always be true so I think all these lines are not used and should be removed.

[ki.stfu]

Remove IDE_MI_APP_EXIT_xxx messages

tools/lldb-mi/MIDriverMgr.cpp

CMIDriverMgr::Shutdown(void)
 
     bool vbAppExitOk = true;
 
     ClrErrorDescription();
 
     if (!m_bInitialized)
         return MIstatus::success;
 
     if (vbAppExitOk)
     {
-#if _DEBUG
-        CMICmnStreamStdout::Instance().Write(MIRSRC(IDE_MI_APP_EXIT_OK)); // Both stdout and Log
-#else
-        CMICmnLog::WriteLog(MIRSRC(IDE_MI_APP_EXIT_OK)); // Just to the Log
-#endif // _DEBUG
+        CMICmnLog::WriteLog(MIRSRC(IDE_MI_APP_EXIT_OK));
     }
     else
     {
         CMICmnLog &rAppLog = CMICmnLog::Instance();
         if (rAppLog.GetEnabled())
         {
             const CMIUtilString msg(
                 CMIUtilString::Format(MIRSRC(IDE_MI_APP_EXIT_WITH_PROBLEM), CMICmnLogMediumFile::Instance().GetFileName().c_str()));
             CMICmnStreamStdout::Instance().Write(msg);
         }
         else
         {
             const CMIUtilString msg(
                 CMIUtilString::Format(MIRSRC(IDE_MI_APP_EXIT_WITH_PROBLEM_NO_LOG), CMICmnLogMediumFile::Instance().GetFileName().c_str()));
             CMICmnStreamStdout::Instance().Write(msg);
         }
     }
 
     m_bInitialized = false;
 
     bool bOk = MIstatus::success;
     CMIUtilString errMsg;
 
     // Tidy up
     UnregisterDriverAll();