Added check for kind of UnqualifiedId in Declarator::isStaticMember()

[violetav]

Summary

Method CXXMethodDecl::isStaticOverloadedOperator expects Operator field from the struct OperatorFunctionId, which is a member of the union in the class UnqualifiedId. If the kind of UnqualifiedId is not checked, there is no guarantee that the value that this method receives will be correct, because it can be the value of another union member and not OperatorFunctionId.

[violetav]

ping

[rnk]

lgtm

Thanks for the fix!

[petarj]

lgtm

lib/Sema/DeclSpec.cpp

bool Declarator::isDeclarationOfFunction() const {
   }
 
   llvm_unreachable("Invalid TypeSpecType!");
 }
 
 bool Declarator::isStaticMember() {
   assert(getContext() == MemberContext);
   return getDeclSpec().getStorageClassSpec() == DeclSpec::SCS_static ||
+         (getName().Kind == UnqualifiedId::IK_OperatorFunctionId &&
           CXXMethodDecl::isStaticOverloadedOperator(
-             getName().OperatorFunctionId.Operator);
+              getName().OperatorFunctionId.Operator));
 }
 
 bool DeclSpec::hasTagDefinition() const {
   if (!TypeSpecOwned)
     return false;
   return cast<TagDecl>(getRepAsDecl())->isCompleteDefinition();
 }