This is an archive of the discontinued LLVM Phabricator instance.

Remove .CUDAIsDevice flags from CodeGenOpts as it's already available in LangOpts.
ClosedPublic

Authored by tra on Mar 17 2015, 10:57 AM.

Diff Detail

Event Timeline

tra updated this revision to Diff 22105.Mar 17 2015, 10:57 AM
tra retitled this revision from to Remove .CUDAIsDevice flags from CodeGenOpts as it's already available in LangOpts..
tra updated this object.
tra edited the test plan for this revision. (Show Details)
tra added reviewers: echristo, eliben.
tra added a subscriber: Unknown Object (MLST).
eliben accepted this revision.Mar 17 2015, 12:38 PM
eliben edited edge metadata.

LGTM

I'd ask pcc@ if he remembers why this was ever created, just out of curiosity

This revision is now accepted and ready to land.Mar 17 2015, 12:38 PM
echristo edited edge metadata.Mar 17 2015, 12:52 PM

The functionality itself is necessary and this one predates the langopt by
3 years. Probably just a lack of migrating the code when it was moved to
langopt.

-eric

This revision was automatically updated to reflect the committed changes.