This is an archive of the discontinued LLVM Phabricator instance.

Differential D83847

[lldb][NFC] Add 'override' where missing in source/ and tools/
ClosedPublic

Authored by logan-5 on Jul 14 2020, 10:13 PM.

Details

Reviewers
clayborg
Commits
rG44b43a52dc17: [lldb][NFC] Add 'override' where missing in source/ and tools/
Summary

These were found by Clang's new -Wsuggest-override.

This patch doesn't touch any code in unittests/, since much of it intentionally doesn't use override to avoid massive warning spam from -Winconsistent-missing-override due to the use of MOCK_*** macros.

Diff Detail

Event Timeline

logan-5 created this revision.Jul 14 2020, 10:13 PM
Herald added a subscriber: lldb-commits. · View Herald TranscriptJul 14 2020, 10:13 PM
Harbormaster failed remote builds in B64286: Diff 278068!Jul 14 2020, 10:36 PM
clayborg accepted this revision.Jul 15 2020, 11:17 AM
This revision is now accepted and ready to land.Jul 15 2020, 11:17 AM
Closed by commit rG44b43a52dc17: [lldb][NFC] Add 'override' where missing in source/ and tools/ (authored by logan-5). · Explain WhyJul 15 2020, 11:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
source/
Plugins/
Process/
MacOSX-Kernel/
4 lines
16 lines
16 lines
12 lines
12 lines
16 lines
Utility/
16 lines
12 lines
12 lines
SymbolVendor/
MacOSX/
4 lines
Symbol/
4 lines
tools/
debugserver/
source/
MacOSX/
i386/
70 lines
x86_64/
72 lines

Diff 278263

lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp

Show First 20 Lines • Show All 867 Lines • ▼ Show 20 Lines
} }
class CommandObjectProcessKDPPacketSend : public CommandObjectParsed { class CommandObjectProcessKDPPacketSend : public CommandObjectParsed {
private: private:
OptionGroupOptions m_option_group; OptionGroupOptions m_option_group;
OptionGroupUInt64 m_command_byte; OptionGroupUInt64 m_command_byte;
OptionGroupString m_packet_data; OptionGroupString m_packet_data;
virtual Options *GetOptions() { return &m_option_group; } Options *GetOptions() override { return &m_option_group; }
public: public:
CommandObjectProcessKDPPacketSend(CommandInterpreter &interpreter) CommandObjectProcessKDPPacketSend(CommandInterpreter &interpreter)
: CommandObjectParsed(interpreter, "process plugin packet send", : CommandObjectParsed(interpreter, "process plugin packet send",
"Send a custom packet through the KDP protocol by " "Send a custom packet through the KDP protocol by "
"specifying the command byte and the packet " "specifying the command byte and the packet "
"payload data. A packet will be sent with a " "payload data. A packet will be sent with a "
"correct header and payload, and the raw result " "correct header and payload, and the raw result "
Show All 10 Lines CommandObjectProcessKDPPacketSend(CommandInterpreter &interpreter)
NULL) { NULL) {
m_option_group.Append(&m_command_byte, LLDB_OPT_SET_ALL, LLDB_OPT_SET_1); m_option_group.Append(&m_command_byte, LLDB_OPT_SET_ALL, LLDB_OPT_SET_1);
m_option_group.Append(&m_packet_data, LLDB_OPT_SET_ALL, LLDB_OPT_SET_1); m_option_group.Append(&m_packet_data, LLDB_OPT_SET_ALL, LLDB_OPT_SET_1);
m_option_group.Finalize(); m_option_group.Finalize();
} }
~CommandObjectProcessKDPPacketSend() {} ~CommandObjectProcessKDPPacketSend() {}
bool DoExecute(Args &command, CommandReturnObject &result) { bool DoExecute(Args &command, CommandReturnObject &result) override {
const size_t argc = command.GetArgumentCount(); const size_t argc = command.GetArgumentCount();
if (argc == 0) { if (argc == 0) {
if (!m_command_byte.GetOptionValue().OptionWasSet()) { if (!m_command_byte.GetOptionValue().OptionWasSet()) {
result.AppendError( result.AppendError(
"the --command option must be set to a valid command byte"); "the --command option must be set to a valid command byte");
result.SetStatus(eReturnStatusFailed); result.SetStatus(eReturnStatusFailed);
} else { } else {
const uint64_t command_byte = const uint64_t command_byte =
▲ Show 20 Lines • Show All 121 Lines • Show Last 20 Lines

lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_arm.h

Show All 14 Lines
class RegisterContextKDP_arm : public RegisterContextDarwin_arm { class RegisterContextKDP_arm : public RegisterContextDarwin_arm {
public: public:
RegisterContextKDP_arm(ThreadKDP &thread, uint32_t concrete_frame_idx); RegisterContextKDP_arm(ThreadKDP &thread, uint32_t concrete_frame_idx);
virtual ~RegisterContextKDP_arm(); virtual ~RegisterContextKDP_arm();
protected: protected:
virtual int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr); int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr) override;
int DoReadFPU(lldb::tid_t tid, int flavor, FPU &fpu); int DoReadFPU(lldb::tid_t tid, int flavor, FPU &fpu) override;
int DoReadEXC(lldb::tid_t tid, int flavor, EXC &exc); int DoReadEXC(lldb::tid_t tid, int flavor, EXC &exc) override;
int DoReadDBG(lldb::tid_t tid, int flavor, DBG &dbg); int DoReadDBG(lldb::tid_t tid, int flavor, DBG &dbg) override;
int DoWriteGPR(lldb::tid_t tid, int flavor, const GPR &gpr); int DoWriteGPR(lldb::tid_t tid, int flavor, const GPR &gpr) override;
int DoWriteFPU(lldb::tid_t tid, int flavor, const FPU &fpu); int DoWriteFPU(lldb::tid_t tid, int flavor, const FPU &fpu) override;
int DoWriteEXC(lldb::tid_t tid, int flavor, const EXC &exc); int DoWriteEXC(lldb::tid_t tid, int flavor, const EXC &exc) override;
int DoWriteDBG(lldb::tid_t tid, int flavor, const DBG &dbg); int DoWriteDBG(lldb::tid_t tid, int flavor, const DBG &dbg) override;
ThreadKDP &m_kdp_thread; ThreadKDP &m_kdp_thread;
}; };
#endif // LLDB_SOURCE_PLUGINS_PROCESS_MACOSX_KERNEL_REGISTERCONTEXTKDP_ARM_H #endif // LLDB_SOURCE_PLUGINS_PROCESS_MACOSX_KERNEL_REGISTERCONTEXTKDP_ARM_H

lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_arm64.h

Show All 15 Lines
class RegisterContextKDP_arm64 : public RegisterContextDarwin_arm64 { class RegisterContextKDP_arm64 : public RegisterContextDarwin_arm64 {
public: public:
RegisterContextKDP_arm64(ThreadKDP &thread, uint32_t concrete_frame_idx); RegisterContextKDP_arm64(ThreadKDP &thread, uint32_t concrete_frame_idx);
virtual ~RegisterContextKDP_arm64(); virtual ~RegisterContextKDP_arm64();
protected: protected:
virtual int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr); int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr) override;
int DoReadFPU(lldb::tid_t tid, int flavor, FPU &fpu); int DoReadFPU(lldb::tid_t tid, int flavor, FPU &fpu) override;
int DoReadEXC(lldb::tid_t tid, int flavor, EXC &exc); int DoReadEXC(lldb::tid_t tid, int flavor, EXC &exc) override;
int DoReadDBG(lldb::tid_t tid, int flavor, DBG &dbg); int DoReadDBG(lldb::tid_t tid, int flavor, DBG &dbg) override;
int DoWriteGPR(lldb::tid_t tid, int flavor, const GPR &gpr); int DoWriteGPR(lldb::tid_t tid, int flavor, const GPR &gpr) override;
int DoWriteFPU(lldb::tid_t tid, int flavor, const FPU &fpu); int DoWriteFPU(lldb::tid_t tid, int flavor, const FPU &fpu) override;
int DoWriteEXC(lldb::tid_t tid, int flavor, const EXC &exc); int DoWriteEXC(lldb::tid_t tid, int flavor, const EXC &exc) override;
int DoWriteDBG(lldb::tid_t tid, int flavor, const DBG &dbg); int DoWriteDBG(lldb::tid_t tid, int flavor, const DBG &dbg) override;
ThreadKDP &m_kdp_thread; ThreadKDP &m_kdp_thread;
}; };
#endif // LLDB_SOURCE_PLUGINS_PROCESS_MACOSX_KERNEL_REGISTERCONTEXTKDP_ARM64_H #endif // LLDB_SOURCE_PLUGINS_PROCESS_MACOSX_KERNEL_REGISTERCONTEXTKDP_ARM64_H

lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_i386.h

Show All 14 Lines
class RegisterContextKDP_i386 : public RegisterContextDarwin_i386 { class RegisterContextKDP_i386 : public RegisterContextDarwin_i386 {
public: public:
RegisterContextKDP_i386(ThreadKDP &thread, uint32_t concrete_frame_idx); RegisterContextKDP_i386(ThreadKDP &thread, uint32_t concrete_frame_idx);
virtual ~RegisterContextKDP_i386(); virtual ~RegisterContextKDP_i386();
protected: protected:
virtual int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr); int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr) override;
int DoReadFPU(lldb::tid_t tid, int flavor, FPU &fpu); int DoReadFPU(lldb::tid_t tid, int flavor, FPU &fpu) override;
int DoReadEXC(lldb::tid_t tid, int flavor, EXC &exc); int DoReadEXC(lldb::tid_t tid, int flavor, EXC &exc) override;
int DoWriteGPR(lldb::tid_t tid, int flavor, const GPR &gpr); int DoWriteGPR(lldb::tid_t tid, int flavor, const GPR &gpr) override;
int DoWriteFPU(lldb::tid_t tid, int flavor, const FPU &fpu); int DoWriteFPU(lldb::tid_t tid, int flavor, const FPU &fpu) override;
int DoWriteEXC(lldb::tid_t tid, int flavor, const EXC &exc); int DoWriteEXC(lldb::tid_t tid, int flavor, const EXC &exc) override;
ThreadKDP &m_kdp_thread; ThreadKDP &m_kdp_thread;
}; };
#endif // LLDB_SOURCE_PLUGINS_PROCESS_MACOSX_KERNEL_REGISTERCONTEXTKDP_I386_H #endif // LLDB_SOURCE_PLUGINS_PROCESS_MACOSX_KERNEL_REGISTERCONTEXTKDP_I386_H

lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_x86_64.h

Show All 14 Lines
class RegisterContextKDP_x86_64 : public RegisterContextDarwin_x86_64 { class RegisterContextKDP_x86_64 : public RegisterContextDarwin_x86_64 {
public: public:
RegisterContextKDP_x86_64(ThreadKDP &thread, uint32_t concrete_frame_idx); RegisterContextKDP_x86_64(ThreadKDP &thread, uint32_t concrete_frame_idx);
virtual ~RegisterContextKDP_x86_64(); virtual ~RegisterContextKDP_x86_64();
protected: protected:
virtual int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr); int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr) override;
int DoReadFPU(lldb::tid_t tid, int flavor, FPU &fpu); int DoReadFPU(lldb::tid_t tid, int flavor, FPU &fpu) override;
int DoReadEXC(lldb::tid_t tid, int flavor, EXC &exc); int DoReadEXC(lldb::tid_t tid, int flavor, EXC &exc) override;
int DoWriteGPR(lldb::tid_t tid, int flavor, const GPR &gpr); int DoWriteGPR(lldb::tid_t tid, int flavor, const GPR &gpr) override;
int DoWriteFPU(lldb::tid_t tid, int flavor, const FPU &fpu); int DoWriteFPU(lldb::tid_t tid, int flavor, const FPU &fpu) override;
int DoWriteEXC(lldb::tid_t tid, int flavor, const EXC &exc); int DoWriteEXC(lldb::tid_t tid, int flavor, const EXC &exc) override;
ThreadKDP &m_kdp_thread; ThreadKDP &m_kdp_thread;
}; };
#endif // LLDB_SOURCE_PLUGINS_PROCESS_MACOSX_KERNEL_REGISTERCONTEXTKDP_X86_64_H #endif // LLDB_SOURCE_PLUGINS_PROCESS_MACOSX_KERNEL_REGISTERCONTEXTKDP_X86_64_H

lldb/source/Plugins/Process/MacOSX-Kernel/ThreadKDP.h

Show All 16 Lines
class ProcessKDP; class ProcessKDP;
class ThreadKDP : public lldb_private::Thread { class ThreadKDP : public lldb_private::Thread {
public: public:
ThreadKDP(lldb_private::Process &process, lldb::tid_t tid); ThreadKDP(lldb_private::Process &process, lldb::tid_t tid);
virtual ~ThreadKDP(); virtual ~ThreadKDP();
virtual void RefreshStateAfterStop(); void RefreshStateAfterStop() override;
virtual const char *GetName(); const char *GetName() override;
virtual const char *GetQueueName(); const char *GetQueueName() override;
virtual lldb::RegisterContextSP GetRegisterContext(); lldb::RegisterContextSP GetRegisterContext() override;
virtual lldb::RegisterContextSP lldb::RegisterContextSP
CreateRegisterContextForFrame(lldb_private::StackFrame *frame); CreateRegisterContextForFrame(lldb_private::StackFrame *frame) override;
void Dump(lldb_private::Log *log, uint32_t index); void Dump(lldb_private::Log *log, uint32_t index);
static bool ThreadIDIsValid(lldb::tid_t thread); static bool ThreadIDIsValid(lldb::tid_t thread);
bool ShouldStop(bool &step_more); bool ShouldStop(bool &step_more);
const char *GetBasicInfoAsString(); const char *GetBasicInfoAsString();
void SetName(const char *name) { void SetName(const char *name) override {
if (name && name[0]) if (name && name[0])
m_thread_name.assign(name); m_thread_name.assign(name);
else else
m_thread_name.clear(); m_thread_name.clear();
} }
lldb::addr_t GetThreadDispatchQAddr() { return m_thread_dispatch_qaddr; } lldb::addr_t GetThreadDispatchQAddr() { return m_thread_dispatch_qaddr; }
void SetThreadDispatchQAddr(lldb::addr_t thread_dispatch_qaddr) { void SetThreadDispatchQAddr(lldb::addr_t thread_dispatch_qaddr) {
m_thread_dispatch_qaddr = thread_dispatch_qaddr; m_thread_dispatch_qaddr = thread_dispatch_qaddr;
} }
void SetStopInfoFrom_KDP_EXCEPTION( void SetStopInfoFrom_KDP_EXCEPTION(
const lldb_private::DataExtractor &exc_reply_packet); const lldb_private::DataExtractor &exc_reply_packet);
protected: protected:
friend class ProcessKDP; friend class ProcessKDP;
// Member variables. // Member variables.
std::string m_thread_name; std::string m_thread_name;
std::string m_dispatch_queue_name; std::string m_dispatch_queue_name;
lldb::addr_t m_thread_dispatch_qaddr; lldb::addr_t m_thread_dispatch_qaddr;
lldb::StopInfoSP m_cached_stop_info_sp; lldb::StopInfoSP m_cached_stop_info_sp;
// Protected member functions. // Protected member functions.
virtual bool CalculateStopInfo(); bool CalculateStopInfo() override;
}; };
#endif // LLDB_SOURCE_PLUGINS_PROCESS_MACOSX_KERNEL_THREADKDP_H #endif // LLDB_SOURCE_PLUGINS_PROCESS_MACOSX_KERNEL_THREADKDP_H

lldb/source/Plugins/Process/Utility/RegisterContextMach_arm.h

Show All 13 Lines
class RegisterContextMach_arm : public RegisterContextDarwin_arm { class RegisterContextMach_arm : public RegisterContextDarwin_arm {
public: public:
RegisterContextMach_arm(lldb_private::Thread &thread, RegisterContextMach_arm(lldb_private::Thread &thread,
uint32_t concrete_frame_idx); uint32_t concrete_frame_idx);
virtual ~RegisterContextMach_arm(); virtual ~RegisterContextMach_arm();
protected: protected:
virtual int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr); int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr) override;
int DoReadFPU(lldb::tid_t tid, int flavor, FPU &fpu); int DoReadFPU(lldb::tid_t tid, int flavor, FPU &fpu) override;
int DoReadEXC(lldb::tid_t tid, int flavor, EXC &exc); int DoReadEXC(lldb::tid_t tid, int flavor, EXC &exc) override;
int DoReadDBG(lldb::tid_t tid, int flavor, DBG &dbg); int DoReadDBG(lldb::tid_t tid, int flavor, DBG &dbg) override;
int DoWriteGPR(lldb::tid_t tid, int flavor, const GPR &gpr); int DoWriteGPR(lldb::tid_t tid, int flavor, const GPR &gpr) override;
int DoWriteFPU(lldb::tid_t tid, int flavor, const FPU &fpu); int DoWriteFPU(lldb::tid_t tid, int flavor, const FPU &fpu) override;
int DoWriteEXC(lldb::tid_t tid, int flavor, const EXC &exc); int DoWriteEXC(lldb::tid_t tid, int flavor, const EXC &exc) override;
int DoWriteDBG(lldb::tid_t tid, int flavor, const DBG &dbg); int DoWriteDBG(lldb::tid_t tid, int flavor, const DBG &dbg) override;
}; };
#endif // LLDB_SOURCE_PLUGINS_PROCESS_UTILITY_REGISTERCONTEXTMACH_ARM_H #endif // LLDB_SOURCE_PLUGINS_PROCESS_UTILITY_REGISTERCONTEXTMACH_ARM_H

lldb/source/Plugins/Process/Utility/RegisterContextMach_i386.h

Show All 13 Lines
class RegisterContextMach_i386 : public RegisterContextDarwin_i386 { class RegisterContextMach_i386 : public RegisterContextDarwin_i386 {
public: public:
RegisterContextMach_i386(lldb_private::Thread &thread, RegisterContextMach_i386(lldb_private::Thread &thread,
uint32_t concrete_frame_idx); uint32_t concrete_frame_idx);
virtual ~RegisterContextMach_i386(); virtual ~RegisterContextMach_i386();
protected: protected:
virtual int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr); int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr) override;
int DoReadFPU(lldb::tid_t tid, int flavor, FPU &fpu); int DoReadFPU(lldb::tid_t tid, int flavor, FPU &fpu) override;
int DoReadEXC(lldb::tid_t tid, int flavor, EXC &exc); int DoReadEXC(lldb::tid_t tid, int flavor, EXC &exc) override;
int DoWriteGPR(lldb::tid_t tid, int flavor, const GPR &gpr); int DoWriteGPR(lldb::tid_t tid, int flavor, const GPR &gpr) override;
int DoWriteFPU(lldb::tid_t tid, int flavor, const FPU &fpu); int DoWriteFPU(lldb::tid_t tid, int flavor, const FPU &fpu) override;
int DoWriteEXC(lldb::tid_t tid, int flavor, const EXC &exc); int DoWriteEXC(lldb::tid_t tid, int flavor, const EXC &exc) override;
}; };
#endif // LLDB_SOURCE_PLUGINS_PROCESS_UTILITY_REGISTERCONTEXTMACH_I386_H #endif // LLDB_SOURCE_PLUGINS_PROCESS_UTILITY_REGISTERCONTEXTMACH_I386_H

lldb/source/Plugins/Process/Utility/RegisterContextMach_x86_64.h

Show All 14 Lines
class RegisterContextMach_x86_64 : public RegisterContextDarwin_x86_64 { class RegisterContextMach_x86_64 : public RegisterContextDarwin_x86_64 {
public: public:
RegisterContextMach_x86_64(lldb_private::Thread &thread, RegisterContextMach_x86_64(lldb_private::Thread &thread,
uint32_t concrete_frame_idx); uint32_t concrete_frame_idx);
virtual ~RegisterContextMach_x86_64(); virtual ~RegisterContextMach_x86_64();
protected: protected:
virtual int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr); int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr) override;
int DoReadFPU(lldb::tid_t tid, int flavor, FPU &fpu); int DoReadFPU(lldb::tid_t tid, int flavor, FPU &fpu) override;
int DoReadEXC(lldb::tid_t tid, int flavor, EXC &exc); int DoReadEXC(lldb::tid_t tid, int flavor, EXC &exc) override;
int DoWriteGPR(lldb::tid_t tid, int flavor, const GPR &gpr); int DoWriteGPR(lldb::tid_t tid, int flavor, const GPR &gpr) override;
int DoWriteFPU(lldb::tid_t tid, int flavor, const FPU &fpu); int DoWriteFPU(lldb::tid_t tid, int flavor, const FPU &fpu) override;
int DoWriteEXC(lldb::tid_t tid, int flavor, const EXC &exc); int DoWriteEXC(lldb::tid_t tid, int flavor, const EXC &exc) override;
}; };
#endif // LLDB_SOURCE_PLUGINS_PROCESS_UTILITY_REGISTERCONTEXTMACH_X86_64_H #endif // LLDB_SOURCE_PLUGINS_PROCESS_UTILITY_REGISTERCONTEXTMACH_X86_64_H

lldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.h

Show All 27 Lines CreateInstance(const lldb::ModuleSP &module_sp,
lldb_private::Stream *feedback_strm); lldb_private::Stream *feedback_strm);
// Constructors and Destructors // Constructors and Destructors
SymbolVendorMacOSX(const lldb::ModuleSP &module_sp); SymbolVendorMacOSX(const lldb::ModuleSP &module_sp);
virtual ~SymbolVendorMacOSX(); virtual ~SymbolVendorMacOSX();
// PluginInterface protocol // PluginInterface protocol
virtual lldb_private::ConstString GetPluginName(); lldb_private::ConstString GetPluginName() override;
virtual uint32_t GetPluginVersion(); uint32_t GetPluginVersion() override;
private: private:
SymbolVendorMacOSX(const SymbolVendorMacOSX &) = delete; SymbolVendorMacOSX(const SymbolVendorMacOSX &) = delete;
const SymbolVendorMacOSX &operator=(const SymbolVendorMacOSX &) = delete; const SymbolVendorMacOSX &operator=(const SymbolVendorMacOSX &) = delete;
}; };
#endif // LLDB_SOURCE_PLUGINS_SYMBOLVENDOR_MACOSX_SYMBOLVENDORMACOSX_H #endif // LLDB_SOURCE_PLUGINS_SYMBOLVENDOR_MACOSX_SYMBOLVENDORMACOSX_H

lldb/source/Symbol/FuncUnwinders.cpp

Show First 20 Lines • Show All 177 Lines • ▼ Show 20 LinesUnwindPlanSP FuncUnwinders::GetArmUnwindUnwindPlan(Target &target) {
return m_unwind_plan_arm_unwind_sp; return m_unwind_plan_arm_unwind_sp;
} }
namespace { namespace {
class RegisterContextToInfo: public SymbolFile::RegisterInfoResolver { class RegisterContextToInfo: public SymbolFile::RegisterInfoResolver {
public: public:
RegisterContextToInfo(RegisterContext &ctx) : m_ctx(ctx) {} RegisterContextToInfo(RegisterContext &ctx) : m_ctx(ctx) {}
const RegisterInfo *ResolveName(llvm::StringRef name) const { const RegisterInfo *ResolveName(llvm::StringRef name) const override {
return m_ctx.GetRegisterInfoByName(name); return m_ctx.GetRegisterInfoByName(name);
} }
const RegisterInfo *ResolveNumber(lldb::RegisterKind kind, const RegisterInfo *ResolveNumber(lldb::RegisterKind kind,
uint32_t number) const { uint32_t number) const override {
return m_ctx.GetRegisterInfo(kind, number); return m_ctx.GetRegisterInfo(kind, number);
} }
private: private:
RegisterContext &m_ctx; RegisterContext &m_ctx;
}; };
} // namespace } // namespace
▲ Show 20 Lines • Show All 364 Lines • Show Last 20 Lines

lldb/tools/debugserver/source/MacOSX/i386/DNBArchImplI386.h

Show All 25 Lines
public: public:
DNBArchImplI386(MachThread *thread) DNBArchImplI386(MachThread *thread)
: DNBArchProtocol(), m_thread(thread), m_state(), m_2pc_dbg_checkpoint(), : DNBArchProtocol(), m_thread(thread), m_state(), m_2pc_dbg_checkpoint(),
m_2pc_trans_state(Trans_Done), m_saved_register_states() {} m_2pc_trans_state(Trans_Done), m_saved_register_states() {}
virtual ~DNBArchImplI386() {} virtual ~DNBArchImplI386() {}
static void Initialize(); static void Initialize();
virtual bool GetRegisterValue(uint32_t set, uint32_t reg, bool GetRegisterValue(uint32_t set, uint32_t reg,
DNBRegisterValue *value); DNBRegisterValue *value) override;
virtual bool SetRegisterValue(uint32_t set, uint32_t reg, bool SetRegisterValue(uint32_t set, uint32_t reg,
const DNBRegisterValue *value); const DNBRegisterValue *value) override;
virtual nub_size_t GetRegisterContext(void *buf, nub_size_t buf_len); nub_size_t GetRegisterContext(void *buf, nub_size_t buf_len) override;
virtual nub_size_t SetRegisterContext(const void *buf, nub_size_t buf_len); nub_size_t SetRegisterContext(const void *buf, nub_size_t buf_len) override;
virtual uint32_t SaveRegisterState(); uint32_t SaveRegisterState() override;
virtual bool RestoreRegisterState(uint32_t save_id); bool RestoreRegisterState(uint32_t save_id) override;
virtual kern_return_t GetRegisterState(int set, bool force); kern_return_t GetRegisterState(int set, bool force) override;
virtual kern_return_t SetRegisterState(int set); kern_return_t SetRegisterState(int set) override;
virtual bool RegisterSetStateIsValid(int set) const; bool RegisterSetStateIsValid(int set) const override;
virtual uint64_t GetPC(uint64_t failValue); // Get program counter uint64_t GetPC(uint64_t failValue) override; // Get program counter
virtual kern_return_t SetPC(uint64_t value); kern_return_t SetPC(uint64_t value) override;
virtual uint64_t GetSP(uint64_t failValue); // Get stack pointer uint64_t GetSP(uint64_t failValue) override; // Get stack pointer
virtual void ThreadWillResume(); void ThreadWillResume() override;
virtual bool ThreadDidStop(); bool ThreadDidStop() override;
virtual bool NotifyException(MachException::Data &exc); bool NotifyException(MachException::Data &exc) override;
virtual uint32_t NumSupportedHardwareBreakpoints(); uint32_t NumSupportedHardwareBreakpoints() override;
virtual uint32_t NumSupportedHardwareWatchpoints(); uint32_t NumSupportedHardwareWatchpoints() override;
virtual uint32_t EnableHardwareBreakpoint(nub_addr_t addr, nub_size_t size, uint32_t EnableHardwareBreakpoint(nub_addr_t addr, nub_size_t size,
bool also_set_on_task); bool also_set_on_task) override;
virtual bool DisableHardwareBreakpoint(uint32_t hw_index, bool DisableHardwareBreakpoint(uint32_t hw_index,
bool also_set_on_task); bool also_set_on_task) override;
virtual uint32_t EnableHardwareWatchpoint(nub_addr_t addr, nub_size_t size, uint32_t EnableHardwareWatchpoint(nub_addr_t addr, nub_size_t size,
bool read, bool write, bool read, bool write,
bool also_set_on_task); bool also_set_on_task) override;
virtual bool DisableHardwareWatchpoint(uint32_t hw_break_index, bool DisableHardwareWatchpoint(uint32_t hw_break_index,
bool also_set_on_task); bool also_set_on_task) override;
virtual uint32_t GetHardwareWatchpointHit(nub_addr_t &addr); uint32_t GetHardwareWatchpointHit(nub_addr_t &addr) override;
protected: protected:
kern_return_t EnableHardwareSingleStep(bool enable); kern_return_t EnableHardwareSingleStep(bool enable);
typedef __i386_thread_state_t GPR; typedef __i386_thread_state_t GPR;
typedef __i386_float_state_t FPU; typedef __i386_float_state_t FPU;
typedef __i386_exception_state_t EXC; typedef __i386_exception_state_t EXC;
typedef __i386_avx_state_t AVX; typedef __i386_avx_state_t AVX;
▲ Show 20 Lines • Show All 149 Lines • ▼ Show 20 Lines static void SetWatchpoint(DBG &debug_state, uint32_t hw_index,
nub_addr_t addr, nub_size_t size, bool read, nub_addr_t addr, nub_size_t size, bool read,
bool write); bool write);
static void ClearWatchpoint(DBG &debug_state, uint32_t hw_index); static void ClearWatchpoint(DBG &debug_state, uint32_t hw_index);
static bool IsWatchpointVacant(const DBG &debug_state, uint32_t hw_index); static bool IsWatchpointVacant(const DBG &debug_state, uint32_t hw_index);
static void ClearWatchpointHits(DBG &debug_state); static void ClearWatchpointHits(DBG &debug_state);
static bool IsWatchpointHit(const DBG &debug_state, uint32_t hw_index); static bool IsWatchpointHit(const DBG &debug_state, uint32_t hw_index);
static nub_addr_t GetWatchAddress(const DBG &debug_state, uint32_t hw_index); static nub_addr_t GetWatchAddress(const DBG &debug_state, uint32_t hw_index);
virtual bool StartTransForHWP(); bool StartTransForHWP() override;
virtual bool RollbackTransForHWP(); bool RollbackTransForHWP() override;
virtual bool FinishTransForHWP(); bool FinishTransForHWP() override;
DBG GetDBGCheckpoint(); DBG GetDBGCheckpoint();
MachThread *m_thread; MachThread *m_thread;
State m_state; State m_state;
DBG m_2pc_dbg_checkpoint; DBG m_2pc_dbg_checkpoint;
uint32_t m_2pc_trans_state; // Is transaction of DBG state change: Pedning uint32_t m_2pc_trans_state; // Is transaction of DBG state change: Pedning
// (0), Done (1), or Rolled Back (2)? // (0), Done (1), or Rolled Back (2)?
typedef std::map<uint32_t, Context> SaveRegisterStates; typedef std::map<uint32_t, Context> SaveRegisterStates;
SaveRegisterStates m_saved_register_states; SaveRegisterStates m_saved_register_states;
}; };
#endif // #if defined (__i386__) || defined (__x86_64__) #endif // #if defined (__i386__) || defined (__x86_64__)
#endif // LLDB_TOOLS_DEBUGSERVER_SOURCE_MACOSX_I386_DNBARCHIMPLI386_H #endif // LLDB_TOOLS_DEBUGSERVER_SOURCE_MACOSX_I386_DNBARCHIMPLI386_H

lldb/tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.h

Show All 24 Lines
public: public:
DNBArchImplX86_64(MachThread *thread) DNBArchImplX86_64(MachThread *thread)
: DNBArchProtocol(), m_thread(thread), m_state(), m_2pc_dbg_checkpoint(), : DNBArchProtocol(), m_thread(thread), m_state(), m_2pc_dbg_checkpoint(),
m_2pc_trans_state(Trans_Done), m_saved_register_states() {} m_2pc_trans_state(Trans_Done), m_saved_register_states() {}
virtual ~DNBArchImplX86_64() {} virtual ~DNBArchImplX86_64() {}
static void Initialize(); static void Initialize();
virtual bool GetRegisterValue(uint32_t set, uint32_t reg, bool GetRegisterValue(uint32_t set, uint32_t reg,
DNBRegisterValue *value); DNBRegisterValue *value) override;
virtual bool SetRegisterValue(uint32_t set, uint32_t reg, bool SetRegisterValue(uint32_t set, uint32_t reg,
const DNBRegisterValue *value); const DNBRegisterValue *value) override;
virtual nub_size_t GetRegisterContext(void *buf, nub_size_t buf_len); nub_size_t GetRegisterContext(void *buf, nub_size_t buf_len) override;
virtual nub_size_t SetRegisterContext(const void *buf, nub_size_t buf_len); nub_size_t SetRegisterContext(const void *buf, nub_size_t buf_len) override;
virtual uint32_t SaveRegisterState(); uint32_t SaveRegisterState() override;
virtual bool RestoreRegisterState(uint32_t save_id); bool RestoreRegisterState(uint32_t save_id) override;
virtual kern_return_t GetRegisterState(int set, bool force); kern_return_t GetRegisterState(int set, bool force) override;
virtual kern_return_t SetRegisterState(int set); kern_return_t SetRegisterState(int set) override;
virtual bool RegisterSetStateIsValid(int set) const; bool RegisterSetStateIsValid(int set) const override;
virtual uint64_t GetPC(uint64_t failValue); // Get program counter uint64_t GetPC(uint64_t failValue) override; // Get program counter
virtual kern_return_t SetPC(uint64_t value); kern_return_t SetPC(uint64_t value) override;
virtual uint64_t GetSP(uint64_t failValue); // Get stack pointer uint64_t GetSP(uint64_t failValue) override; // Get stack pointer
virtual void ThreadWillResume(); void ThreadWillResume() override;
virtual bool ThreadDidStop(); bool ThreadDidStop() override;
virtual bool NotifyException(MachException::Data &exc); bool NotifyException(MachException::Data &exc) override;
virtual uint32_t NumSupportedHardwareBreakpoints(); uint32_t NumSupportedHardwareBreakpoints() override;
virtual uint32_t NumSupportedHardwareWatchpoints(); uint32_t NumSupportedHardwareWatchpoints() override;
virtual uint32_t EnableHardwareBreakpoint(nub_addr_t addr, nub_size_t size, uint32_t EnableHardwareBreakpoint(nub_addr_t addr, nub_size_t size,
bool also_set_on_task); bool also_set_on_task) override;
virtual bool DisableHardwareBreakpoint(uint32_t hw_break_index, bool DisableHardwareBreakpoint(uint32_t hw_break_index,
bool also_set_on_task); bool also_set_on_task) override;
virtual uint32_t EnableHardwareWatchpoint(nub_addr_t addr, nub_size_t size, uint32_t EnableHardwareWatchpoint(nub_addr_t addr, nub_size_t size,
bool read, bool write, bool read, bool write,
bool also_set_on_task); bool also_set_on_task) override;
virtual bool DisableHardwareWatchpoint(uint32_t hw_break_index, bool DisableHardwareWatchpoint(uint32_t hw_break_index,
bool also_set_on_task); bool also_set_on_task) override;
virtual uint32_t GetHardwareWatchpointHit(nub_addr_t &addr); uint32_t GetHardwareWatchpointHit(nub_addr_t &addr) override;
protected: protected:
kern_return_t EnableHardwareSingleStep(bool enable); kern_return_t EnableHardwareSingleStep(bool enable);
typedef __x86_64_thread_state_t GPR; typedef __x86_64_thread_state_t GPR;
typedef __x86_64_float_state_t FPU; typedef __x86_64_float_state_t FPU;
typedef __x86_64_exception_state_t EXC; typedef __x86_64_exception_state_t EXC;
typedef __x86_64_avx_state_t AVX; typedef __x86_64_avx_state_t AVX;
▲ Show 20 Lines • Show All 153 Lines • ▼ Show 20 Lines static void SetWatchpoint(DBG &debug_state, uint32_t hw_index,
nub_addr_t addr, nub_size_t size, bool read, nub_addr_t addr, nub_size_t size, bool read,
bool write); bool write);
static void ClearWatchpoint(DBG &debug_state, uint32_t hw_index); static void ClearWatchpoint(DBG &debug_state, uint32_t hw_index);
static bool IsWatchpointVacant(const DBG &debug_state, uint32_t hw_index); static bool IsWatchpointVacant(const DBG &debug_state, uint32_t hw_index);
static void ClearWatchpointHits(DBG &debug_state); static void ClearWatchpointHits(DBG &debug_state);
static bool IsWatchpointHit(const DBG &debug_state, uint32_t hw_index); static bool IsWatchpointHit(const DBG &debug_state, uint32_t hw_index);
static nub_addr_t GetWatchAddress(const DBG &debug_state, uint32_t hw_index); static nub_addr_t GetWatchAddress(const DBG &debug_state, uint32_t hw_index);
virtual bool StartTransForHWP(); bool StartTransForHWP() override;
virtual bool RollbackTransForHWP(); bool RollbackTransForHWP() override;
virtual bool FinishTransForHWP(); bool FinishTransForHWP() override;
DBG GetDBGCheckpoint(); DBG GetDBGCheckpoint();
MachThread *m_thread; MachThread *m_thread;
State m_state; State m_state;
DBG m_2pc_dbg_checkpoint; DBG m_2pc_dbg_checkpoint;
uint32_t m_2pc_trans_state; // Is transaction of DBG state change: Pedning uint32_t m_2pc_trans_state; // Is transaction of DBG state change: Pedning
// (0), Done (1), or Rolled Back (2)? // (0), Done (1), or Rolled Back (2)?
typedef std::map<uint32_t, Context> SaveRegisterStates; typedef std::map<uint32_t, Context> SaveRegisterStates;
SaveRegisterStates m_saved_register_states; SaveRegisterStates m_saved_register_states;
}; };
#endif // #if defined (__i386__) || defined (__x86_64__) #endif // #if defined (__i386__) || defined (__x86_64__)
#endif // LLDB_TOOLS_DEBUGSERVER_SOURCE_MACOSX_X86_64_DNBARCHIMPLX86_64_H #endif // LLDB_TOOLS_DEBUGSERVER_SOURCE_MACOSX_X86_64_DNBARCHIMPLX86_64_H