Seems pretty good. Pending the driver aspect rewrite we might want a -### test that verifies the particular phases and commands that are coming out?
Complete test for cuda-related driver pipeline construction is part of the
driver changes I'll send in a bit. Stay tuned.
I think that test will make sense when we get the pipeline up and going so LGTM for this part.
Simplified/cleaned up included test case.
As we mentioned we'll need to split the testcase out to avoid leaving temporary files etc as well. Use -### and split accordingly to test the various features.
Updated test case to avoid creation of temporary files.
Removed unnecessary preprocessing and run compiler checks on the file combined with -x cuda-cpp-output.
Much better, some inline comments.
Probably best to avoid most of this comment and just say what you're testing here.
Can you move these up by the test that they're from?
Cleaned up the test case.
LGTM. Thanks for all of the revisions!
Committed in http://reviews.llvm.org/rL232737