Page MenuHomePhabricator

Ensure that we still parse preprocessed CUDA files as CUDA when we use -save-temps option.
ClosedPublic

Authored by tra on Mar 17 2015, 10:36 AM.

Details

Reviewers
echristo
Summary

Fixes PR22926.

Diff Detail

Event Timeline

tra updated this revision to Diff 22102.Mar 17 2015, 10:36 AM
tra retitled this revision from to Ensure that we still parse preprocessed CUDA files as CUDA when we use -save-temps option..
tra updated this object.
tra edited the test plan for this revision. (Show Details)
tra added a reviewer: echristo.
tra added a subscriber: Unknown Object (MLST).
echristo edited edge metadata.Mar 18 2015, 11:32 AM

Seems pretty good. Pending the driver aspect rewrite we might want a -### test that verifies the particular phases and commands that are coming out?

-eric

tra added a comment.Mar 18 2015, 11:50 AM

Complete test for cuda-related driver pipeline construction is part of the
driver changes I'll send in a bit. Stay tuned.

echristo accepted this revision.Mar 18 2015, 11:57 AM
echristo edited edge metadata.

I think that test will make sense when we get the pipeline up and going so LGTM for this part.

-eric

This revision is now accepted and ready to land.Mar 18 2015, 11:57 AM
tra updated this revision to Diff 22214.Mar 18 2015, 2:46 PM
tra edited edge metadata.

Simplified/cleaned up included test case.

echristo requested changes to this revision.Mar 18 2015, 3:43 PM
echristo edited edge metadata.

As we mentioned we'll need to split the testcase out to avoid leaving temporary files etc as well. Use -### and split accordingly to test the various features.

-eric

This revision now requires changes to proceed.Mar 18 2015, 3:43 PM
tra updated this revision to Diff 22219.Mar 18 2015, 3:49 PM
tra edited edge metadata.

Updated test case to avoid creation of temporary files.

Updating D8383: Ensure that we still parse preprocessed CUDA files as CUDA when we use

-save-temps option.

tra updated this revision to Diff 22222.Mar 18 2015, 4:02 PM
tra edited edge metadata.

Removed unnecessary preprocessing and run compiler checks on the file combined with -x cuda-cpp-output.

Updating D8383: Ensure that we still parse preprocessed CUDA files as CUDA when we use

-save-temps option.

Much better, some inline comments.

Thanks!

-eric

test/Driver/cuda-simple.cu
6

Probably best to avoid most of this comment and just say what you're testing here.

22

Can you move these up by the test that they're from?

tra updated this revision to Diff 22227.Mar 18 2015, 4:19 PM

Cleaned up the test case.

Updating D8383: Ensure that we still parse preprocessed CUDA files as CUDA when we use

-save-temps option.

echristo accepted this revision.Mar 18 2015, 4:20 PM
echristo edited edge metadata.

LGTM. Thanks for all of the revisions!

-eric

This revision is now accepted and ready to land.Mar 18 2015, 4:20 PM