[ObjC] Wrap namespace-global structure in an anonymous namespace to avoid ODR violations

[davide]

Summary

rdar://problem/65537147

[teemperor]

This seems to resolve the -Wodr build issues from what I can see, so LGTM. I guess the next step is drawing straws to see who has to refactor this code into something readable...

[shafik]

It does indeed solve the immediate problem but if those namespaces aren't really meant to be shared across translation units they should have different names but that is for another PR.

lldb/source/Plugins/Language/ObjC/NSArray.cpp

protected:
   uint64_t GetSize() override;
 
 private:
   D32 *m_data_32;
   D64 *m_data_64;
 };
   
 namespace Foundation1010 {
+  namespace {
     struct DataDescriptor_32 {
       uint32_t _used;
       uint32_t _offset;
       uint32_t _size : 28;
       uint64_t _priv1 : 4;
       uint32_t _priv2;
       uint32_t _data;
     };
     
     struct DataDescriptor_64 {
       uint64_t _used;
       uint64_t _offset;
       uint64_t _size : 60;
       uint64_t _priv1 : 4;
       uint32_t _priv2;
       uint64_t _data;
     };
+  }
   
   using NSArrayMSyntheticFrontEnd =
       GenericNSArrayMSyntheticFrontEnd<DataDescriptor_32, DataDescriptor_64>;
 }
   
 namespace Foundation1428 {
+  namespace {
     struct DataDescriptor_32 {
       uint32_t _used;
       uint32_t _offset;
       uint32_t _size;
       uint32_t _data;
     };
     
     struct DataDescriptor_64 {
       uint64_t _used;
       uint64_t _offset;
       uint64_t _size;
       uint64_t _data;
     };
+  }
   
   using NSArrayMSyntheticFrontEnd =
       GenericNSArrayMSyntheticFrontEnd<DataDescriptor_32, DataDescriptor_64>;
 }
   
 namespace Foundation1437 {
   template <typename PtrType>
   struct DataDescriptor {

lldb/source/Plugins/Language/ObjC/NSDictionary.cpp

private:
     DataDescriptor_32 *m_data_32;
     DataDescriptor_64 *m_data_64;
     CompilerType m_pair_type;
     std::vector<DictionaryItemDescriptor> m_children;
   };
 }
   
 namespace Foundation1428 {
+  namespace {
     struct DataDescriptor_32 {
       uint32_t _used : 26;
       uint32_t _kvo : 1;
       uint32_t _size;
       uint32_t _buffer;
       uint64_t GetSize() { return _size; }
     };
     
     struct DataDescriptor_64 {
       uint64_t _used : 58;
       uint32_t _kvo : 1;
       uint64_t _size;
       uint64_t _buffer;
       uint64_t GetSize() { return _size; }
     };
-  
-  
-  
+  }
   using NSDictionaryMSyntheticFrontEnd =
     GenericNSDictionaryMSyntheticFrontEnd<DataDescriptor_32, DataDescriptor_64>;
 }
   
 namespace Foundation1437 {
+  namespace {
     static const uint64_t NSDictionaryCapacities[] = {
         0, 3, 7, 13, 23, 41, 71, 127, 191, 251, 383, 631, 1087, 1723,
         2803, 4523, 7351, 11959, 19447, 31231, 50683, 81919, 132607,
         214519, 346607, 561109, 907759, 1468927, 2376191, 3845119,
         6221311, 10066421, 16287743, 26354171, 42641881, 68996069,
         111638519, 180634607, 292272623, 472907251
     };
     
-  static const size_t NSDictionaryNumSizeBuckets = sizeof(NSDictionaryCapacities) / sizeof(uint64_t);
+    static const size_t NSDictionaryNumSizeBuckets =
+        sizeof(NSDictionaryCapacities) / sizeof(uint64_t);
     
     struct DataDescriptor_32 {
       uint32_t _buffer;
       uint32_t _muts;
       uint32_t _used : 25;
       uint32_t _kvo : 1;
       uint32_t _szidx : 6;
 
       uint64_t GetSize() {
         return (_szidx) >= NSDictionaryNumSizeBuckets ?
             0 : NSDictionaryCapacities[_szidx];
       }
     };
     
     struct DataDescriptor_64 {
       uint64_t _buffer;
       uint32_t _muts;
       uint32_t _used : 25;
       uint32_t _kvo : 1;
       uint32_t _szidx : 6;
 
       uint64_t GetSize() {
         return (_szidx) >= NSDictionaryNumSizeBuckets ?
             0 : NSDictionaryCapacities[_szidx];
       }
     };
+  }
   
   using NSDictionaryMSyntheticFrontEnd =
     GenericNSDictionaryMSyntheticFrontEnd<DataDescriptor_32, DataDescriptor_64>;
   
   template <typename DD>
   uint64_t
   __NSDictionaryMSize_Impl(lldb_private::Process &process,
                            lldb::addr_t valobj_addr, Status &error) {