This is an archive of the discontinued LLVM Phabricator instance.

Add a decorator to skip tests when running under Rosetta
ClosedPublic

Authored by aprantl on Jul 10 2020, 5:16 PM.

Details

Summary

This allows skipping a test when running the testsuite on macOS under the Rosetta translation layer.

Diff Detail

Event Timeline

aprantl created this revision.Jul 10 2020, 5:16 PM
davide accepted this revision.Jul 10 2020, 8:12 PM

Good, one minor suggestion.

lldb/packages/Python/lldbsuite/test/decorators.py
560

There might be a more direct way of checking this, maybe machine(). We used platform().uname() for internal limitations & machine not always returning the right string, but it should be fixed on Beta 1 (and beyond) for sure

This revision is now accepted and ready to land.Jul 10 2020, 8:12 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2020, 1:11 PM