This is an archive of the discontinued LLVM Phabricator instance.

Differential D8347

Use -fno-limit-debug-info instead of -fstandalone-debug
ClosedPublic

Authored by vharron on Mar 15 2015, 10:16 AM.

Details

Reviewers
clayborg
Commits
rGb63c1880f211: Use -fno-limit-debug-info instead of -fstandalone-debug in tests
rLLDB232326: Use -fno-limit-debug-info instead of -fstandalone-debug in tests
rL232326: Use -fno-limit-debug-info instead of -fstandalone-debug in tests
Summary

This fixes tests on clang-3.4

AFAICT, these flags have the same affect and -fstandalone-debug wasn't added until after clang-3.4

Diff Detail

Repository
rL LLVM

Event Timeline

vharron updated this revision to Diff 21996.Mar 15 2015, 10:16 AM
vharron retitled this revision from to Use -fno-limit-debug-info instead of -fstandalone-debug.
vharron updated this object.
vharron edited the test plan for this revision. (Show Details)
vharron added a reviewer: clayborg.
vharron set the repository for this revision to rL LLVM.
vharron added a subscriber: Unknown Object (MLST).
Closed by commit rL232326: Use -fno-limit-debug-info instead of -fstandalone-debug in tests (authored by vharron). · Explain WhyMar 15 2015, 11:08 AM
This revision was automatically updated to reflect the committed changes.
clayborg edited edge metadata.Mar 16 2015, 10:02 AM

As long as top of tree llvm+clang are good with this change it should be fine.

Revision Contents

PathSize
expression_command/
call-function/
2 lines
functionalities/
data-formatter/
data-formatter-skip-summary/
2 lines
data-formatter-stl/
libstdcpp/
iterator/
2 lines
list/
2 lines
string/
2 lines
data-formatter-synth/
2 lines
rdar-9974002/
2 lines
stringprinter/
2 lines
type_completion/
2 lines
lang/
cpp/
stl/
2 lines
python_api/
sbvalue_persist/
2 lines

Diff 21996

expression_command/call-function/Makefile

Context not available.
# targets. Other targets do not, which causes this test to fail. # targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets. # This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC))) ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS := -fstandalone-debug CFLAGS_EXTRAS := -fno-limit-debug-info
endif endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules
Context not available.

functionalities/data-formatter/data-formatter-skip-summary/Makefile

Context not available.
# targets. Other targets do not, which causes this test to fail. # targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets. # This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC))) ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS := -fstandalone-debug CFLAGS_EXTRAS := -fno-limit-debug-info
endif endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules
Context not available.

functionalities/data-formatter/data-formatter-stl/libstdcpp/iterator/Makefile

Context not available.
# targets. Other targets do not, which causes this test to fail. # targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets. # This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC))) ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS := -fstandalone-debug CFLAGS_EXTRAS := -fno-limit-debug-info
endif endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules
Context not available.

functionalities/data-formatter/data-formatter-stl/libstdcpp/list/Makefile

Context not available.
# targets. Other targets do not, which causes this test to fail. # targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets. # This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC))) ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fstandalone-debug CFLAGS_EXTRAS += -fno-limit-debug-info
endif endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules
Context not available.

functionalities/data-formatter/data-formatter-stl/libstdcpp/string/Makefile

Context not available.
# targets. Other targets do not, which causes this test to fail. # targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets. # This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC))) ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fstandalone-debug CFLAGS_EXTRAS += -fno-limit-debug-info
endif endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules
Context not available.

functionalities/data-formatter/data-formatter-synth/Makefile

Context not available.
# targets. Other targets do not, which causes this test to fail. # targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets. # This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC))) ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS := -fstandalone-debug CFLAGS_EXTRAS := -fno-limit-debug-info
endif endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules
Context not available.

functionalities/data-formatter/rdar-9974002/Makefile

Context not available.
# targets. Other targets do not, which causes this test to fail. # targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets. # This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC))) ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS := -fstandalone-debug CFLAGS_EXTRAS := -fno-limit-debug-info
endif endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules
Context not available.

functionalities/data-formatter/stringprinter/Makefile

Context not available.
# targets. Other targets do not, which causes this test to fail. # targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets. # This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC))) ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS := -fstandalone-debug CFLAGS_EXTRAS := -fno-limit-debug-info
endif endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules
Context not available.

functionalities/type_completion/Makefile

Context not available.
# targets. Other targets do not, which causes this test to fail. # targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets. # This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC))) ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fstandalone-debug CFLAGS_EXTRAS += -fno-limit-debug-info
endif endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules
Context not available.

lang/cpp/stl/Makefile

Context not available.
# targets. Other targets do not, which causes this test to fail. # targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets. # This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC))) ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS := -fstandalone-debug CFLAGS_EXTRAS := -fno-limit-debug-info
endif endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules
Context not available.

python_api/sbvalue_persist/Makefile

Context not available.
# targets. Other targets do not, which causes this test to fail. # targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets. # This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC))) ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS := -fstandalone-debug CFLAGS_EXTRAS := -fno-limit-debug-info
endif endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules
Context not available.