This is an archive of the discontinued LLVM Phabricator instance.

[clang][RelativeVTablesABI] Update CodeGenCXX/RelativeVTablesABI/dynamic-cast.cpp
ClosedPublic

Authored by leonardchan on Jun 29 2020, 1:01 PM.

Details

Summary

After c7bcd431d9c4bfeb631a3599f1d628603e6351d6, this test started failing when running with the new pass manager. One of the CHECKs in this file checks how the vtable is loaded for a void cast, which involves taking 2 bitcasts from the pointer to the original object. The order of these bitcasts changes under the new PM. The order doesn't matter, so this relaxes the CHECKs.

Diff Detail

Event Timeline

leonardchan created this revision.Jun 29 2020, 1:01 PM
phosek accepted this revision.Jun 29 2020, 1:04 PM

LGTM

This revision is now accepted and ready to land.Jun 29 2020, 1:04 PM
This revision was automatically updated to reflect the committed changes.