This is an archive of the discontinued LLVM Phabricator instance.

LLParser: Accept align(N) as new syntax for parameter attribute
ClosedPublic

Authored by arsenm on Jun 26 2020, 1:12 PM.

Details

Reviewers
jdoerfert
Summary

Every other value parameter attribute uses parentheses, so accept this
as the preferred modern syntax. Updating everything to use the new
syntax is left for a future change.

Diff Detail

Event Timeline

arsenm created this revision.Jun 26 2020, 1:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2020, 1:12 PM
jdoerfert accepted this revision.Jun 26 2020, 1:29 PM

I think this is clearly improving uniformity of the attribute spelling. Thanks. Align was first but is not "special" anymore (in the attribute position).

This revision is now accepted and ready to land.Jun 26 2020, 1:29 PM