This is an archive of the discontinued LLVM Phabricator instance.

test/msan/sigwait: Don't silently ignore assertion failures
ClosedPublic

Authored by guiand on Jun 23 2020, 11:23 AM.

Details

Summary

As the parent process would return 0 independent of whether the child succeeded, assertions in the child would be ignored.

Diff Detail

Event Timeline

guiand created this revision.Jun 23 2020, 11:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 23 2020, 11:23 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
eugenis accepted this revision.Jun 23 2020, 12:12 PM

LGTM with nit

compiler-rt/test/msan/sigwait.cpp
25

_exit(!WIFEXITED(child_stat))

This revision is now accepted and ready to land.Jun 23 2020, 12:12 PM
guiand updated this revision to Diff 272800.Jun 23 2020, 12:41 PM

Changed to use WIFEXITED

guiand marked an inline comment as done.Jun 23 2020, 12:41 PM
This revision was automatically updated to reflect the committed changes.