[lldb/Lua] Use the debugger's output and error file for Lua's I/O library.

[JDevlieghere]

Summary

Add support for changing the stdout and stderr file in Lua's I/O library and hook it up with the debugger's output and error file respectively for the interactive Lua interpreter.

[labath]

I have some questions (but no definitive answers) inline...

lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp

64

What should be the behavior if this is null? Can it even be null (should we be asserting that it isn't)?
It's not clear to me that we should be reusing the previously set stdout if these arguments are null... Maybe we should be saving the original stdout value and restoring it when we are done? That's what the python interpreter seems to be doing..

65–66

lua_getfield(m_lua_state, -1, "stdout")

68

I guess it would be better to use luaL_testudata(m_lua_state, -1, LUA_FILEHANDLE) as that also checks that the user data is of the expected type (and e.g. it was not replaced by the user).

Or it might actually be better to just overwrite the value of io.stdout/err with a new value/userdata object, instead of fiddling with the existing one.

[JDevlieghere]

lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp

64

I don't really see a benefit to storing it, I'm fine with just asserting that the file is not null.

[labath]

lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp

64

Ok, that's fine. But then you should remove the =nullptr default arguments.

[JDevlieghere]

Forgot the Differential revision in front of the phab URL. Closed by fa1b4a96a0110c87cdd83eb4ea3e9a0d002c3c3d

lldb/source/Plugins/ScriptInterpreter/Lua/Lua.h

public:
 
   ~Lua() {
     assert(m_lua_state);
     luaL_openlibs(m_lua_state);
   }
 
   llvm::Error Run(llvm::StringRef buffer);
   llvm::Error LoadModule(llvm::StringRef filename);
+  llvm::Error ChangeIO(FILE *out = nullptr, FILE *err = nullptr);
 
 private:
   lua_State *m_lua_state;
 };
 
 } // namespace lldb_private
 
 #endif // liblldb_Lua_h_

lldb/source/Plugins/ScriptInterpreter/Lua/Lua.cpp

if (error) {
     lua_pop(m_lua_state, 1);
     return e;
   }
 
   ConstString module_name = file.GetFileNameStrippingExtension();
   lua_setglobal(m_lua_state, module_name.GetCString());
   return llvm::Error::success();
 }
+
+llvm::Error Lua::ChangeIO(FILE *out, FILE *err) {
+  lua_getglobal(m_lua_state, "io");
+
+  if (out) {
+    lua_pushstring(m_lua_state, "stdout");
+    lua_gettable(m_lua_state, -2);
+    luaL_Stream *s =
+        static_cast<luaL_Stream *>(lua_touserdata(m_lua_state, -1));
+    if (!s) {
+      lua_pop(m_lua_state, 2);
+      return llvm::make_error<llvm::StringError>(
+          "could not get stdout", llvm::inconvertibleErrorCode());
+    }
+    s->f = out;
+    lua_pop(m_lua_state, 1);
+  }
+
+  if (err) {
+    lua_pushstring(m_lua_state, "stderr");
+    lua_gettable(m_lua_state, -2);
+    luaL_Stream *s =
+        static_cast<luaL_Stream *>(lua_touserdata(m_lua_state, -1));
+    if (!s) {
+      lua_pop(m_lua_state, 2);
+      return llvm::make_error<llvm::StringError>(
+          "could not get stderr", llvm::inconvertibleErrorCode());
+    }
+    s->f = out;
+    lua_pop(m_lua_state, 1);
+  }
+
+  lua_pop(m_lua_state, 1);
+  return llvm::Error::success();
+}

lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp

class IOHandlerLuaInterpreter : public IOHandlerDelegate,
                                 public IOHandlerEditline {
 public:
   IOHandlerLuaInterpreter(Debugger &debugger,
                           ScriptInterpreterLua &script_interpreter)
       : IOHandlerEditline(debugger, IOHandler::Type::LuaInterpreter, "lua",
                           ">>> ", "..> ", true, debugger.GetUseColor(), 0,
                           *this, nullptr),
         m_script_interpreter(script_interpreter) {
+    llvm::cantFail(m_script_interpreter.GetLua().ChangeIO(
+        debugger.GetOutputFile().GetStream(),
+        debugger.GetErrorFile().GetStream()));
     llvm::cantFail(m_script_interpreter.EnterSession(debugger.GetID()));
   }
 
   ~IOHandlerLuaInterpreter() override {
     llvm::cantFail(m_script_interpreter.LeaveSession());
   }
 
   void IOHandlerInputComplete(IOHandler &io_handler,

lldb/test/Shell/ScriptInterpreter/Lua/io.test

+# REQUIRES: lua
+# UNSUPPORTED: lldb-repro
+#
+# RUN: cat %s | %lldb --script-language lua 2> %t.stderr > %t.stdout
+# RUN: cat %t.stdout | FileCheck %s --check-prefix STDOUT
+# RUN: cat %t.stderr | FileCheck %s --check-prefix STDERR
+script
+file = lldb.SBFile(2, "w", false)
+lldb.debugger:SetOutputFile(file)
+io.write(95000 + 126, "\n")
+quit
+script
+io.write(95000 + 14, "\n")
+# STDOUT: 95126
+# STDOUT-NOT: 95014
+# STDERR: 95014