Add strcmp function to libc.

[abrachet]

Are you using the arc tool to create these? I've always had trouble with it too. You can create a diff and upload that diff or copy and paste it in Phab, which I think is a lot easier and less error prone. git diff origin -U99999 > patch then you can upload patch from reviews.llvm.org. Hopefully thats helpful

[cgyurgyik]

In D82133#2102309, @abrachet wrote:

Are you using the arc tool to create these? I've always had trouble with it too. You can create a diff and upload that diff or copy and paste it in Phab, which I think is a lot easier and less error prone. git diff origin -U99999 > patch then you can upload patch from reviews.llvm.org. Hopefully thats helpful

Thank you! Yes, as you can tell, I'm struggling a bit with arc. I will look into this approach; it sounds a lot better.

libc/test/src/string/strcmp_test.cpp

 
 TEST(StrCmpTest, EmptyStringsShouldReturnZero) {
   const char *s1 = "";
   const char *s2 = "";
   const int result = __llvm_libc::strcmp(s1, s2);
   ASSERT_EQ(result, 0);
 }
 
-<<<<<<< HEAD
 TEST(StrCmpTest, EmptyStringShouldNotEqualNonEmptyString) {
   const char *empty = "";
   const char *s2 = "abc";
   int result = __llvm_libc::strcmp(empty, s2);
   // This should be '\0' - 'a' = -97
   ASSERT_EQ(result, -97);
   
   // Similar case if empty string is second argument.
   const char *s3 = "123";
   result = __llvm_libc::strcmp(s3, empty);
   // This should be '1' - '\0' = 49
   ASSERT_EQ(result, 49);
 }
 
-=======
->>>>>>> 3e77db0445101d39c49274da6c375b8792e510b9
 TEST(StrCmpTest, EqualStringsShouldReturnZero) {
   const char *s1 = "abc";
   const char *s2 = "abc";
   const int result = __llvm_libc::strcmp(s1, s2);
   ASSERT_EQ(result, 0);
 }
 
 TEST(StrCmpTest, ShouldReturnResultOfFirstDifference) {
-<<<<<<< HEAD
   const char *s1 = "___B42__";
   const char *s2 = "___C55__";
   const int result = __llvm_libc::strcmp(s1, s2);
   // This should return 'B' - 'C' = -1.
-=======
-  const char *s1 = "aaaB42";
-  const char *s2 = "aaaC55";
-  const int result = __llvm_libc::strcmp(s1, s2);
-  // This should return 'C' - 'B', which is equal to -1.
->>>>>>> 3e77db0445101d39c49274da6c375b8792e510b9
   ASSERT_EQ(result, -1);
 }
 
 TEST(StrCmpTest, CapitalizedLetterShouldNotBeEqual) {
-<<<<<<< HEAD
   const char *s1 = "abcd";
   const char *s2 = "abCd";
   const int result = __llvm_libc::strcmp(s1, s2);
   // 'c' - 'C' = 32.
-=======
-  const char *s1 = "abcd";
-  const char *s2 = "abCd";
-  const int result = __llvm_libc::strcmp(s1, s2);
-  // 'c' - 'C' is equal to 32.
->>>>>>> 3e77db0445101d39c49274da6c375b8792e510b9
   ASSERT_EQ(result, 32);
 }
 
 TEST(StrCmpTest, UnequalLengthStringsShouldNotReturnZero) {
-<<<<<<< HEAD
   const char *s1 = "abc";
   const char *s2 = "abcd";
   const int result = __llvm_libc::strcmp(s1, s2);
   // '\0' - 'd' = -100.
   ASSERT_EQ(result, -100);
 }
 
 TEST(StrCmpTest, StringArgumentSwapChangesSign) {
   const char *a = "a";
   const char *b = "b";
   int result = __llvm_libc::strcmp(b, a);
   // 'b' - 'a' = 1.
   ASSERT_EQ(result, 1);
 
   result = __llvm_libc::strcmp(a, b);
   // 'a' - 'b' = -1.
-=======
-  const char *s1 = "abc";
-  const char *s2 = "abcd";
-  const int result = __llvm_libc::strcmp(s1, s2);
-  // '\0' - 'd' is equal to -100.
-  ASSERT_EQ(result, -100);
-}
-
-TEST(StrCmpTest, OrderingSwapChangesSign) {
-  const char *a = "a";
-  const char *b = "b";
-  int result = __llvm_libc::strcmp(b, a);
-  // 'b' - 'a' is equal to 1.
-  ASSERT_EQ(result, 1);
-
-  result = __llvm_libc::strcmp(a, b);
-  // 'a' - 'b' is equal to -1.
->>>>>>> 3e77db0445101d39c49274da6c375b8792e510b9
   ASSERT_EQ(result, -1);
 }