This is an archive of the discontinued LLVM Phabricator instance.

Differential D81976

[NFC] Use EXPECT_FALSE(...) in test rather than EXPECT_EQ(false, ...)
ClosedPublic

Authored by ctetreau on Jun 16 2020, 3:28 PM.

Details

Reviewers
None
Commits
rG1a1849c99b89: [NFC] Use EXPECT_FALSE(...) in test rather than EXPECT_EQ(false, ...)
Summary

Silence GCC -Wconversion-null warning from GTest

Diff Detail

Event Timeline

ctetreau created this revision.Jun 16 2020, 3:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2020, 3:28 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Jun 16 2020, 3:56 PM
Closed by commit rG1a1849c99b89: [NFC] Use EXPECT_FALSE(...) in test rather than EXPECT_EQ(false, ...) (authored by ctetreau). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B60560: Diff 271231.Jun 16 2020, 5:01 PM

Revision Contents

PathSize
llvm/
unittests/
IR/
2 lines

Diff 271236

llvm/unittests/IR/ModuleTest.cpp

Show First 20 Lines • Show All 106 Lines • ▼ Show 20 Lines
)IR"; )IR";
TEST(ModuleTest, setProfileSummary) { TEST(ModuleTest, setProfileSummary) {
SMDiagnostic Err; SMDiagnostic Err;
LLVMContext Context; LLVMContext Context;
std::unique_ptr<Module> M = parseAssemblyString(IRString, Err, Context); std::unique_ptr<Module> M = parseAssemblyString(IRString, Err, Context);
auto *PS = ProfileSummary::getFromMD(M->getProfileSummary(/*IsCS*/ false)); auto *PS = ProfileSummary::getFromMD(M->getProfileSummary(/*IsCS*/ false));
EXPECT_NE(nullptr, PS); EXPECT_NE(nullptr, PS);
EXPECT_EQ(false, PS->isPartialProfile()); EXPECT_FALSE(PS->isPartialProfile());
PS->setPartialProfile(true); PS->setPartialProfile(true);
M->setProfileSummary(PS->getMD(Context), ProfileSummary::PSK_Sample); M->setProfileSummary(PS->getMD(Context), ProfileSummary::PSK_Sample);
delete PS; delete PS;
PS = ProfileSummary::getFromMD(M->getProfileSummary(/*IsCS*/ false)); PS = ProfileSummary::getFromMD(M->getProfileSummary(/*IsCS*/ false));
EXPECT_NE(nullptr, PS); EXPECT_NE(nullptr, PS);
EXPECT_EQ(true, PS->isPartialProfile()); EXPECT_EQ(true, PS->isPartialProfile());
delete PS; delete PS;
} }
Show All 38 Lines