[AST] Dump containsErrors bit for the Type.

[sammccall]

Can we add a test at least for the text dump?

clang/lib/AST/TextNodeDumper.cpp

205

IIRC in the expr case we used a color, does that make sense here?

[hokein]

add tests.

clang/lib/AST/TextNodeDumper.cpp

205

yeah, in the expr we use a color, but here I don't have a strong opinion -- the other dependence bits don't use color as well, so I'd keep consistent.

[sammccall]

clang/lib/AST/TextNodeDumper.cpp

205

IMO it's at least as important to be consistent in how "contains-errors" is displayed, than it is that it's displayed in the same way as other bits.

I think this bit is special enough to warrant a color, but happy without... in that case we should drop it from exprs.

[hokein]

address comment: emit the error-bit with color.

clang/lib/AST/JSONNodeDumper.cpp

 void JSONNodeDumper::Visit(const Type *T) {
   JOS.attribute("id", createPointerRepresentation(T));
 
   if (!T)
     return;
 
   JOS.attribute("kind", (llvm::Twine(T->getTypeClassName()) + "Type").str());
   JOS.attribute("type", createQualType(QualType(T, 0), /*Desugar*/ false));
+  attributeOnlyIfTrue("containsErrors", T->containsErrors());
   attributeOnlyIfTrue("isDependent", T->isDependentType());
   attributeOnlyIfTrue("isInstantiationDependent",
                       T->isInstantiationDependentType());
   attributeOnlyIfTrue("isVariablyModified", T->isVariablyModifiedType());
   attributeOnlyIfTrue("containsUnexpandedPack",
                       T->containsUnexpandedParameterPack());
   attributeOnlyIfTrue("isImported", T->isFromAST());
   InnerTypeVisitor::Visit(T);

clang/lib/AST/TextNodeDumper.cpp

void TextNodeDumper::Visit(const Type *T) {
   OS << " ";
   dumpBareType(QualType(T, 0), false);
 
   QualType SingleStepDesugar =
       T->getLocallyUnqualifiedSingleStepDesugaredType();
   if (SingleStepDesugar != QualType(T, 0))
     OS << " sugar";
 
+  if (T->containsErrors()) {
+    ColorScope Color(OS, ShowColors, ErrorsColor);
+    OS << " contains-errors";
+  }
+
   if (T->isDependentType())
     OS << " dependent";
   else if (T->isInstantiationDependentType())
     OS << " instantiation_dependent";
 
   if (T->isVariablyModifiedType())
     OS << " variably_modified";
   if (T->containsUnexpandedParameterPack())

clang/test/AST/ast-dump-types-errors-json.cpp

+// RUN: not %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ast-dump=json -ast-dump-filter Test %s | FileCheck %s
+
+using TestContainsErrors = int[sizeof(undef())];
+
+
+// CHECK:  "kind": "TypeAliasDecl",
+// CHECK-NEXT:  "loc": {
+// CHECK-NEXT:   "offset": 130,
+// CHECK-NEXT:   "file": "{{.*}}",
+// CHECK-NEXT:   "line": 3,
+// CHECK-NEXT:   "col": 7,
+// CHECK-NEXT:   "tokLen": 18
+// CHECK-NEXT:  },
+// CHECK-NEXT:  "range": {
+// CHECK-NEXT:   "begin": {
+// CHECK-NEXT:    "offset": 124,
+// CHECK-NEXT:    "col": 1,
+// CHECK-NEXT:    "tokLen": 5
+// CHECK-NEXT:   },
+// CHECK-NEXT:   "end": {
+// CHECK-NEXT:    "offset": 170,
+// CHECK-NEXT:    "col": 47,
+// CHECK-NEXT:    "tokLen": 1
+// CHECK-NEXT:   }
+// CHECK-NEXT:  },
+// CHECK-NEXT:  "name": "TestContainsErrors",
+// CHECK-NEXT:  "type": {
+// CHECK-NEXT:   "qualType": "int [sizeof (<recovery-expr>(undef))]"
+// CHECK-NEXT:  },
+// CHECK-NEXT:  "inner": [
+// CHECK-NEXT:   {
+// CHECK-NEXT:    "id": "0x{{.*}}",
+// CHECK-NEXT:    "kind": "DependentSizedArrayType",
+// CHECK-NEXT:    "type": {
+// CHECK-NEXT:     "qualType": "int [sizeof (<recovery-expr>(undef))]"
+// CHECK-NEXT:    },
+// CHECK-NEXT:    "containsErrors": true,
+// CHECK-NEXT:    "isDependent": true,
+// CHECK-NEXT:    "isInstantiationDependent": true,
+// CHECK-NEXT:    "inner": [
+// CHECK-NEXT:     {
+// CHECK-NEXT:      "id": "0x{{.*}}",
+// CHECK-NEXT:      "kind": "BuiltinType",
+// CHECK-NEXT:      "type": {
+// CHECK-NEXT:       "qualType": "int"
+// CHECK-NEXT:      }
+// CHECK-NEXT:     },
+// CHECK-NEXT:     {
+// CHECK-NEXT:      "id": "0x{{.*}}",
+// CHECK-NEXT:      "kind": "UnaryExprOrTypeTraitExpr",
+// CHECK-NEXT:      "range": {
+// CHECK-NEXT:       "begin": {
+// CHECK-NEXT:        "offset": 155,
+// CHECK-NEXT:        "col": 32,
+// CHECK-NEXT:        "tokLen": 6
+// CHECK-NEXT:       },
+// CHECK-NEXT:       "end": {
+// CHECK-NEXT:        "offset": 169,
+// CHECK-NEXT:        "col": 46,
+// CHECK-NEXT:        "tokLen": 1
+// CHECK-NEXT:       }
+// CHECK-NEXT:      },
+// CHECK-NEXT:      "type": {
+// CHECK-NEXT:       "qualType": "unsigned long"
+// CHECK-NEXT:      },
+// CHECK-NEXT:      "valueCategory": "rvalue",
+// CHECK-NEXT:      "name": "sizeof",
+// CHECK-NEXT:      "inner": [
+// CHECK-NEXT:       {
+// CHECK-NEXT:        "id": "0x{{.*}}",
+// CHECK-NEXT:        "kind": "ParenExpr",
+// CHECK-NEXT:        "range": {
+// CHECK-NEXT:         "begin": {
+// CHECK-NEXT:          "offset": 161,
+// CHECK-NEXT:          "col": 38,
+// CHECK-NEXT:          "tokLen": 1
+// CHECK-NEXT:         },
+// CHECK-NEXT:         "end": {
+// CHECK-NEXT:          "offset": 169,
+// CHECK-NEXT:          "col": 46,
+// CHECK-NEXT:          "tokLen": 1
+// CHECK-NEXT:         }
+// CHECK-NEXT:        },
+// CHECK-NEXT:        "type": {
+// CHECK-NEXT:         "qualType": "<dependent type>"
+// CHECK-NEXT:        },
+// CHECK-NEXT:        "valueCategory": "lvalue",
+// CHECK-NEXT:        "inner": [
+// CHECK-NEXT:         {
+// CHECK-NEXT:          "id": "0x{{.*}}",
+// CHECK-NEXT:          "kind": "RecoveryExpr",
+// CHECK-NEXT:          "range": {
+// CHECK-NEXT:           "begin": {
+// CHECK-NEXT:            "offset": 162,
+// CHECK-NEXT:            "col": 39,
+// CHECK-NEXT:            "tokLen": 5
+// CHECK-NEXT:           },
+// CHECK-NEXT:           "end": {
+// CHECK-NEXT:            "offset": 168,
+// CHECK-NEXT:            "col": 45,
+// CHECK-NEXT:            "tokLen": 1
+// CHECK-NEXT:           }
+// CHECK-NEXT:          },
+// CHECK-NEXT:          "type": {
+// CHECK-NEXT:           "qualType": "<dependent type>"
+// CHECK-NEXT:          },
+// CHECK-NEXT:          "valueCategory": "lvalue",
+// CHECK-NEXT:          "inner": [
+// CHECK-NEXT:           {
+// CHECK-NEXT:            "id": "0x{{.*}}",
+// CHECK-NEXT:            "kind": "UnresolvedLookupExpr",
+// CHECK-NEXT:            "range": {
+// CHECK-NEXT:             "begin": {
+// CHECK-NEXT:              "offset": 162,
+// CHECK-NEXT:              "col": 39,
+// CHECK-NEXT:              "tokLen": 5
+// CHECK-NEXT:             },
+// CHECK-NEXT:             "end": {
+// CHECK-NEXT:              "offset": 162,
+// CHECK-NEXT:              "col": 39,
+// CHECK-NEXT:              "tokLen": 5
+// CHECK-NEXT:             }
+// CHECK-NEXT:            },
+// CHECK-NEXT:            "type": {
+// CHECK-NEXT:             "qualType": "<overloaded function type>"
+// CHECK-NEXT:            },
+// CHECK-NEXT:            "valueCategory": "lvalue",
+// CHECK-NEXT:            "usesADL": true,
+// CHECK-NEXT:            "name": "undef",
+// CHECK-NEXT:            "lookups": []
+// CHECK-NEXT:           }
+// CHECK-NEXT:          ]
+// CHECK-NEXT:         }
+// CHECK-NEXT:        ]
+// CHECK-NEXT:       }
+// CHECK-NEXT:      ]
+// CHECK-NEXT:     }
+// CHECK-NEXT:    ]
+// CHECK-NEXT:   }
+// CHECK-NEXT:  ]
+// CHECK-NEXT: }

clang/test/AST/ast-dump-types-errors.cpp

+// RUN: not %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ast-dump %s | FileCheck %s
+
+void test() {
+  using ContainsErrors = int[sizeof(undef())];
+  // CHECK: DependentSizedArrayType {{.*}} contains-errors dependent
+}