Page MenuHomePhabricator

[lldb] Fix and enable Windows minidump tests
ClosedPublic

Authored by jarin on Jun 9 2020, 6:08 AM.

Details

Summary

SBFileSpec.fullpath always uses the forward slash to join the directory with the base name. This causes mismatches when comparing Windows paths with backslashes in two of the minidump tests. To get around that we just compare the directory names separately from the filenames.

Diff Detail

Event Timeline

jarin created this revision.Jun 9 2020, 6:08 AM
jarin edited the summary of this revision. (Show Details)Jun 9 2020, 6:11 AM
labath accepted this revision.Jun 9 2020, 7:26 AM

Thanks for getting back to this. I think this is a good workaround for the problem (maybe it would be good to make a note of that in the comment). The fullpath implementation should be fixed use the correct path separator, but I haven't yet figured out a good way to do it -- it will probably involve reimplementing fullpath on top of GetPath and fiddling with swig typemaps so that GetPath is usable from python...

This revision is now accepted and ready to land.Jun 9 2020, 7:26 AM
jarin updated this revision to Diff 269609.Jun 9 2020, 11:07 AM

Added a comment.

This revision was automatically updated to reflect the committed changes.