- User Since
- Sep 27 2019, 4:27 AM (20 w, 3 d)
Wed, Feb 12
Thank you for the feedback! I am a bit busy with other things ATM, but I should be able to get back to this next week.
Tue, Feb 11
Fri, Feb 7
Tue, Jan 28
Right, this is pretty clearly my commit. This is a pretty crazy week here, so I am not quite sure when I have time to investigate.
Mon, Jan 27
Pavel, could you take another look, please?
Only matching the mangled name now.
Fri, Jan 24
Pavel, does the latest patch address (and test) what you were worried about?
Updated to include all methods/non-methods with matching mangled name.
Thu, Jan 23
FWIW, the Sony debugger throws away the <type> part of the DW_AT_name and reconstructs it from the template_parameter children. The presence of typedefs and/or enums can make the <type> text inconsistent, especially across enums. Our debugger reconstructs the type-parameters because it's more consistent that way.
Wed, Jan 22
Thanks for the review!
Tue, Jan 21
I changed the diff so that it does not touch Clang's AST importer, instead it patches LLDB's wrapper of the AST importer.
Jan 10 2020
Raphael, could you possibly land the patch for me? Thanks!
Jan 7 2020
Jan 3 2020
Actually, there is something unusually flaky in my current checkout, so you might be right that not canonicalizing is harmless. It still makes more sense to land that separately.
I have addressed the comments, thanks for the quick review.
Dec 17 2019
Dec 16 2019
Nov 21 2019
Nov 19 2019
This update introduces a callback from clang for template specialization. The callback allows lldb to construct instantiations on demand, rather than having to create the instantiation eagerly.
Nov 7 2019
Nov 6 2019
Thanks for the feedback! We will experiment with filtering in GetFunctions sometime next week.
Nov 5 2019
Oct 22 2019
Oct 10 2019
Thank you for the review! Could you also possibly commit the change for me?
Oct 9 2019
Pavel, could you possibly take a look? It looks like Jason is busy with something else...
Oct 4 2019
Oct 2 2019
Fixed the nits, thanks for the careful review!
Oct 1 2019
Fixed a typo.
I have added some comments to the test (I hope it is not too overboard), removed the LEVEL stuff from the Makefile and fixed the formatting.