Page MenuHomePhabricator

jarin (Jaroslav Sevcik)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 27 2019, 4:27 AM (113 w, 5 d)

Recent Activity

Oct 21 2021

jarin committed rG5a3556aa5563: [lldb] Add omitted abstract formal parameters in DWARF symbol files (authored by Jaroslav Sevcik <jarin@chromium.org>).
[lldb] Add omitted abstract formal parameters in DWARF symbol files
Oct 21 2021, 3:35 AM
jarin closed D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.
Oct 21 2021, 3:35 AM · Restricted Project

Oct 6 2021

jarin committed rGfd185cfc513c: Reland "[lldb] Refactor variable parsing" (authored by jarin).
Reland "[lldb] Refactor variable parsing"
Oct 6 2021, 5:26 AM
jarin added a comment to D110570: [lldb] Refactor variable parsing in DWARF symbol file.

Pavel, could you take another look? Interestingly the null-deref problem was already fixed in the follow-up patch, maybe I just did not land quickly enough :-)).

Oct 6 2021, 2:13 AM · Restricted Project
jarin updated the diff for D110570: [lldb] Refactor variable parsing in DWARF symbol file.

Avoid nullptr deref/ref.

Oct 6 2021, 2:02 AM · Restricted Project

Oct 4 2021

jarin added inline comments to D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.
Oct 4 2021, 1:19 PM · Restricted Project
jarin updated the diff for D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.

Addressed Pavel's comments.

Oct 4 2021, 1:18 PM · Restricted Project

Oct 1 2021

jarin added a comment to D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.

Thank you for the great comments, Pavel. I took a stab at merging the parameters without interleaving them with the locals. Let me know what you think; I can certainly put this back to the original state if you think this is a change for the worse.

Oct 1 2021, 6:29 AM · Restricted Project
jarin updated the diff for D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.

Addressed reviewer comments, separated merging of the abstract parameters into a function, prevented interleaving of parameters with locals.

Oct 1 2021, 6:25 AM · Restricted Project
jarin added a comment to D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.

Here's one more question. AIUI, lldb relies on the order of formal parameter declarations in dwarf to establish the the function signature (dwarf doesn't leave us much choice. This then affects how the function is printed in the backtrace, for instance. What will be the resulting order of arguments for these functions? I'm wondering if we don't need a two-pass algorithm, which first parses the arguments in the function declaration (to establish their order), and then do another pass over the concrete instance to fill in the missing information. (I'm sorry if you're doing this already, but I'm still too scared of the code to figure it out myself :P ).

The code already does the merging. For DW_TAG_inlined_subroutine, it first collects the formal_parameter list from from its abstract_origin and then it will parse/insert all the missing one while parsing the concrete instance. This will preserve the order of formal parameters. Now that I think about this, it might add some formal parameters after local variables, but I hope this is not a real problem for LLDB. If this is a problem, we could perhaps flush the abstract formal parameters whenever we encounter DW_TAG_variable.

Cool. I see you're way ahead of me. If you're not careful you may end up as the dwarf maintainer. :P

Oct 1 2021, 1:32 AM · Restricted Project

Sep 30 2021

jarin updated the diff for D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.

Cache only global variables.

Sep 30 2021, 8:34 AM · Restricted Project
jarin added a comment to D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.

Here's one more question. AIUI, lldb relies on the order of formal parameter declarations in dwarf to establish the the function signature (dwarf doesn't leave us much choice. This then affects how the function is printed in the backtrace, for instance. What will be the resulting order of arguments for these functions? I'm wondering if we don't need a two-pass algorithm, which first parses the arguments in the function declaration (to establish their order), and then do another pass over the concrete instance to fill in the missing information. (I'm sorry if you're doing this already, but I'm still too scared of the code to figure it out myself :P ).

Sep 30 2021, 6:36 AM · Restricted Project
jarin updated the diff for D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.

Improved the comment, as Greg suggested.

Sep 30 2021, 12:50 AM · Restricted Project

Sep 29 2021

jarin added a comment to D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.

For illustration:

0x100  DW_TAG_subprogram
         DW_AT_name "inlined_function"
         ... no DW_AT_low_pc here ...
0x110    DW_TAG_formal_parameter
           DW_AT_name "unused"
           ...
       ...
0x200  DW_TAG_subprogram
         DW_AT_name    ("top_level_function_with_address"
         DW_AT_low_pc  (0x3000)
         DW_AT_high_pc  (0x3100)
         ...
0x210    DW_TAG_inlined_subroutine
           DW_AT_abstract_origin (0x100 "inlined_function")
           DW_AT_low_pc  (0x3010)
           DW_AT_high_pc  (0x3020)
           # Note the missing DW_TAG_formal_parameter here!
         NULL
       ...
0x400  DW_TAG_subprogram
         DW_AT_name    ("another_top_level_function_with_address"
         DW_AT_low_pc  (0x5000)
         DW_AT_high_pc  (0x5100)
         ...
0x410    DW_TAG_inlined_subroutine
           DW_AT_abstract_origin (0x100 "inlined_function")
           DW_AT_low_pc  (0x5030)
           DW_AT_high_pc  (0x5040)
           # Note the missing DW_TAG_formal_parameter here!
         NULL
       ...

Here, we will create just one variable for the formal parameter "unused" (DIE offset 0x110). That variable's symbol context will be randomly one of the DW_TAG_inline subroutine blocks (either 0x210 or 0x410), and the variable will be inserted into two variable lists, one for the Block associated with the DIE at 0x210 and one for DIE associated with 0x410.

I hear what you are saying, but I am not sure this will be happening. Let me explain: for each concrete DW_TAG_subprogram (0x200 and 0x400 in your example above), we create a unique lldb_private::Function object whose UserID will be 0x200 for "top_level_function_with_address" and 0x400 for "another_top_level_function_with_address". Each of those functions might be asked for their lldb_private::Block objects at some point and we should create unique lldb_private::Block for each DW_TAG_lexical_block and DW_TAG_inlined_subroutine that is contained within these unique DIEs. Each of these should now have a variable within the block that is a parameter whose name is "unused" and whose symbol context should be 0x210 for the 0x200 DIE, and 0x410 for the 0x400 DIE. So it would be great to make sure this happens correctly. From looking at the code, it seems like this should be happening correctly, but you might know better since you made these new modifications.

Sep 29 2021, 11:21 PM · Restricted Project
jarin added a comment to D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.

First of all, thank you, Greg and Pavel, for all the great feedback and discussion. I have followed all your suggestions (use plain method, use image lookup, added the additional tests). I have also packaged the C test, but as Greg notes I am not convinced it will keep testing what it's supposed to.

Sep 29 2021, 11:22 AM · Restricted Project
jarin updated the diff for D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.

Changed the test to avoid running the process and use image lookup instead of frame variable.

Sep 29 2021, 8:24 AM · Restricted Project
jarin added a comment to D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.

This still uses frame variable rather than image lookup, mostly because frame variable tests better the user experience and the cognitive overhead for making the code runnable does not seem to be too high.

This is not really about "cognitive overhead", but "who can run this test". With a running process the answer is "a person with a linux x86 machine". With image lookup it's "everyone". It's also easier to debug failures in the test, as less code gets run before you get to the interesting part.

Sep 29 2021, 7:50 AM · Restricted Project
jarin updated the diff for D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.

Added a C test (I have also verified that the C test fails without the SymbolFileDWARF patch).

Sep 29 2021, 7:47 AM · Restricted Project
jarin updated the diff for D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.

Rewrote the recursive parser to use a plain method.

Sep 29 2021, 6:46 AM · Restricted Project

Sep 28 2021

jarin added a comment to D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.

Just a few replies below; I am hoping to put the relevant code changes together tomorrow.

Sep 28 2021, 5:51 AM · Restricted Project
jarin added a comment to D110570: [lldb] Refactor variable parsing in DWARF symbol file.

Thank you for the review! Does the separate method look more reasonable?

Sep 28 2021, 5:34 AM · Restricted Project
jarin updated the diff for D110570: [lldb] Refactor variable parsing in DWARF symbol file.

Added the /*can_create=*/ comments.

Sep 28 2021, 5:30 AM · Restricted Project
jarin updated the diff for D110570: [lldb] Refactor variable parsing in DWARF symbol file.

Separated ParseVariablesInFunctionContext's lambda into a method.

Sep 28 2021, 5:23 AM · Restricted Project

Sep 27 2021

jarin added a comment to D110570: [lldb] Refactor variable parsing in DWARF symbol file.

Thank you for taking a look, shafik@. I hope you don't mind if I address your comments later, once a full review arrives from Pavel (or Johannes).

Sep 27 2021, 11:00 PM · Restricted Project
jarin added reviewers for D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files: kimanh, pfaffe.
Sep 27 2021, 12:18 PM · Restricted Project
jarin added reviewers for D110570: [lldb] Refactor variable parsing in DWARF symbol file: kimanh, pfaffe.
Sep 27 2021, 12:17 PM · Restricted Project
jarin added a comment to D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.

Hi, could you take a look at this change?

Sep 27 2021, 12:15 PM · Restricted Project
jarin requested review of D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files.
Sep 27 2021, 11:54 AM · Restricted Project
jarin added a comment to D110570: [lldb] Refactor variable parsing in DWARF symbol file.

Hi, could you possibly take a look at this change?

Sep 27 2021, 10:57 AM · Restricted Project
jarin requested review of D110570: [lldb] Refactor variable parsing in DWARF symbol file.
Sep 27 2021, 10:46 AM · Restricted Project

Aug 4 2021

jarin added a comment to D73191: Only match mangled name in full-name function lookup (with accelerators).

Thanks for getting back to this, Raphael!

Aug 4 2021, 6:22 AM · Restricted Project

Nov 10 2020

jarin accepted D81550: [lldb] Add support for evaluating expressions in static member functions.

This is looking great, thanks!

Nov 10 2020, 12:07 AM · Restricted Project

Oct 28 2020

jarin accepted D90318: Return actual type from SBType::GetArrayElementType.

The code change looks good to me and it is in line with the change that Raphael and Greg wanted in https://reviews.llvm.org/D72133. As far as I remember, https://reviews.llvm.org/D72133 did not change the previous behavior because I felt that changing API semantics was out of scope of what I wanted to do with the formatters.

Oct 28 2020, 11:46 AM · Restricted Project

Sep 14 2020

jarin accepted D87481: [lldb] Ignore certain Clang type sugar when creating the type name.

This makes sense, thanks!

Sep 14 2020, 4:50 AM · Restricted Project

Aug 13 2020

jarin added a comment to D81471: [lldb] Add support for using integral const static data members in the expression evaluator.

I am curious about constexpr static as well here.

Aug 13 2020, 4:00 AM

Aug 11 2020

jarin added inline comments to D81471: [lldb] Add support for using integral const static data members in the expression evaluator.
Aug 11 2020, 9:50 AM
jarin accepted D81471: [lldb] Add support for using integral const static data members in the expression evaluator.

This looks great! Thank you for the extensive test suite.

Aug 11 2020, 7:01 AM
jarin requested review of D85719: Initialize static const fields in the AST for expression evaluation.
Aug 11 2020, 3:26 AM · Restricted Project
jarin accepted D85132: [lldb] Add SubstTemplateTypeParm to RemoveWrappingTypes.

Looks good.

Aug 11 2020, 3:05 AM · Restricted Project

Jul 16 2020

jarin committed rG93ec6cd68426: [lldb] Desugar template specializations (authored by jarin).
[lldb] Desugar template specializations
Jul 16 2020, 12:02 AM
jarin closed D83858: [lldb] Desugar template specializations.
Jul 16 2020, 12:01 AM · Restricted Project

Jul 15 2020

jarin updated the diff for D83858: [lldb] Desugar template specializations.

Undo the infinite loop detection.

Jul 15 2020, 8:29 AM · Restricted Project
jarin added a comment to D83858: [lldb] Desugar template specializations.

This could cause that RemoveWrappingTypes goes into an infinite loop under some situations. Usually this function is reserved for types that are always 'sugar', but TemplateSpecializationTypes are not always sugar (e.g., dependent types are not sugar). And for types that are not sugar, getLocallyUnqualifiedSingleStepDesugaredType will return the type that was passed in. So that will make the loop in that function just keep spinning forever.

Jul 15 2020, 7:10 AM · Restricted Project
jarin updated the diff for D83858: [lldb] Desugar template specializations.

Addressed review comments.

Jul 15 2020, 7:05 AM · Restricted Project
jarin created D83858: [lldb] Desugar template specializations.
Jul 15 2020, 12:48 AM · Restricted Project

Jun 9 2020

jarin committed rGfac5d05eb75f: [lldb] Fix and enable Windows minidump tests (authored by jarin).
[lldb] Fix and enable Windows minidump tests
Jun 9 2020, 1:16 PM
jarin closed D81465: [lldb] Fix and enable Windows minidump tests.
Jun 9 2020, 1:15 PM · Restricted Project
jarin updated the diff for D81465: [lldb] Fix and enable Windows minidump tests.

Added a comment.

Jun 9 2020, 11:32 AM · Restricted Project
jarin updated the summary of D81465: [lldb] Fix and enable Windows minidump tests.
Jun 9 2020, 6:33 AM · Restricted Project
jarin created D81465: [lldb] Fix and enable Windows minidump tests.
Jun 9 2020, 6:32 AM · Restricted Project

Jun 8 2020

jarin committed rG6143874f734b: [lldb] Disable remove-add module test on Windows (authored by jarin).
[lldb] Disable remove-add module test on Windows
Jun 8 2020, 1:36 AM
jarin closed D81363: Disable remove-add module test on Windows.
Jun 8 2020, 1:35 AM · Restricted Project
jarin created D81363: Disable remove-add module test on Windows.
Jun 8 2020, 1:02 AM · Restricted Project
jarin added a reviewer for D81363: Disable remove-add module test on Windows: labath.
Jun 8 2020, 1:02 AM · Restricted Project

Jun 7 2020

jarin committed rG1beffc18886a: Support build-ids of other sizes than 16 in UUID::SetFromStringRef (authored by jarin).
Support build-ids of other sizes than 16 in UUID::SetFromStringRef
Jun 7 2020, 3:09 AM
jarin closed D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef.
Jun 7 2020, 3:09 AM · Restricted Project

Jun 4 2020

jarin updated the diff for D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef.

Exclude UUID strings ending with "-".

Jun 4 2020, 9:20 AM · Restricted Project

Jun 1 2020

jarin updated the diff for D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef.

Added a test for missing nibble in UUID.

Jun 1 2020, 4:16 PM · Restricted Project
jarin added inline comments to D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef.
Jun 1 2020, 2:39 PM · Restricted Project
jarin updated the diff for D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef.

Removed size restrictions on UUIDs.

Jun 1 2020, 2:39 PM · Restricted Project

May 30 2020

jarin updated the diff for D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef.

Change SetFromStringRef to return bool.

May 30 2020, 11:21 PM · Restricted Project

May 29 2020

jarin updated the diff for D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef.
May 29 2020, 8:39 AM · Restricted Project

May 28 2020

jarin added inline comments to D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef.
May 28 2020, 10:59 PM · Restricted Project
jarin created D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef.
May 28 2020, 1:15 PM · Restricted Project

May 25 2020

jarin added a comment to D80254: Prevent GetNumChildren from transitively walking pointer chains.

Raphael, could you land this for me?

May 25 2020, 1:01 AM · Restricted Project

May 22 2020

jarin added a comment to D80254: Prevent GetNumChildren from transitively walking pointer chains.

This looks good, thanks for subscribing me. We need to have GetNumChildren and GetChildAtIndex agreeing on things and we definitely shouldn't be walking more than on pointer recursively. My only question is do we need helper functions added to TypeSystemClang to avoid this issue since we have GetNumChildren and GetChildAtIndex doing things differently? Some function both could/should be calling so that things can't get out of sync?

May 22 2020, 1:13 AM · Restricted Project

May 20 2020

jarin added a comment to D80254: Prevent GetNumChildren from transitively walking pointer chains.

Looks fine to me too. The way this test is phrased, it would probably make more sense under test/API/python_api/value, than here. (I mean, it's not technically wrong because everything is a "functionality", but i'd like to avoid putting stuff here precisely because the category is so vague.)

May 20 2020, 7:35 AM · Restricted Project
jarin updated the diff for D80254: Prevent GetNumChildren from transitively walking pointer chains.

Merged the ObjC pointer case with the reference case, simplified the test.

May 20 2020, 7:34 AM · Restricted Project

May 19 2020

jarin updated the diff for D80254: Prevent GetNumChildren from transitively walking pointer chains.

Added more assertions, reformatted the test code.

May 19 2020, 11:02 PM · Restricted Project
jarin added inline comments to D80254: Prevent GetNumChildren from transitively walking pointer chains.
May 19 2020, 11:02 PM · Restricted Project
jarin created D80254: Prevent GetNumChildren from transitively walking pointer chains.
May 19 2020, 4:00 PM · Restricted Project
jarin added a comment to D79308: [lldb-server] Reset stop reason of all threads when resuming.

Pavel, could you possibly land this for us?

May 19 2020, 3:27 PM · Restricted Project

May 12 2020

jarin added inline comments to D78654: Moving executable module symbols parsing to target creation method..
May 12 2020, 8:01 AM · Restricted Project

May 6 2020

jarin added a comment to D79308: [lldb-server] Reset stop reason of all threads when resuming.

Jim, do you think this is good to go?

May 6 2020, 11:25 PM · Restricted Project

May 5 2020

jarin reopened D73191: Only match mangled name in full-name function lookup (with accelerators).

Reopening for further investigation.

May 5 2020, 12:58 PM · Restricted Project
jarin added inline comments to D79308: [lldb-server] Reset stop reason of all threads when resuming.
May 5 2020, 6:25 AM · Restricted Project
jarin updated the diff for D79308: [lldb-server] Reset stop reason of all threads when resuming.

... now also fixed the 'volatile'. It took only three patches to copy four lines of code by hand. Not bad, huh?

May 5 2020, 6:25 AM · Restricted Project
jarin updated the diff for D79308: [lldb-server] Reset stop reason of all threads when resuming.

... and remove the extra braces.

May 5 2020, 5:52 AM · Restricted Project
jarin updated the diff for D79308: [lldb-server] Reset stop reason of all threads when resuming.

Addressed reviewer comments.

May 5 2020, 5:52 AM · Restricted Project
jarin added a comment to D79404: Fix error handling after [<index>] in 'frame variable'.

Do you think Raphael would want to review this as well? If you think it is not necessary, could you land the patch for me?

May 5 2020, 5:20 AM · Restricted Project
jarin created D79404: Fix error handling after [<index>] in 'frame variable'.
May 5 2020, 4:16 AM · Restricted Project
jarin retitled D79404: Fix error handling after [<index>] in 'frame variable' from Fix handling of [<index>] in 'frame variable' to Fix error handling after [<index>] in 'frame variable'.
May 5 2020, 4:16 AM · Restricted Project

May 4 2020

jarin updated the diff for D79308: [lldb-server] Reset stop reason of all threads when resuming.

Simplify the test based on the suggestion from labath@.

May 4 2020, 7:27 AM · Restricted Project
jarin added a comment to D79308: [lldb-server] Reset stop reason of all threads when resuming.

The test setup here seems unnecessarily complex. Wouldn't an inferior like this work better?

void thread1() {
  pseudo_barrier_wait(g_barrier); // See other tests how this works.
  g_foo = 0; // break_here
}
int main() {
  pseudo_barrier_init(g_barrier1, 2);
  std::thread t1(thread1);
  pseudo_barrier_wait(g_barrier);
  for (int i = 0; i<10000; ++i) g_bar = i; // empty loop to have something to step over
  t1.join();
}

That way you always know only one thread will hit a breakpoint, and and you can just pick the "other" thread as the target for stepping.

May 4 2020, 5:18 AM · Restricted Project

May 3 2020

jarin created D79308: [lldb-server] Reset stop reason of all threads when resuming.
May 3 2020, 2:20 PM · Restricted Project

Apr 22 2020

jarin added inline comments to D78654: Moving executable module symbols parsing to target creation method..
Apr 22 2020, 1:03 PM · Restricted Project

Apr 11 2020

jarin abandoned D77765: Fix incorrect L1 inferior memory cache flushing.
Apr 11 2020, 1:34 AM · Restricted Project
jarin added a comment to D77765: Fix incorrect L1 inferior memory cache flushing.

Abandoning the patch since we cannot reach agreement on how this should be tested.

Apr 11 2020, 1:34 AM · Restricted Project
jarin abandoned D77790: [NFC] Add a test for the inferior memory cache (mainly L1).
Apr 11 2020, 1:34 AM · Restricted Project
jarin added a comment to D77790: [NFC] Add a test for the inferior memory cache (mainly L1).

It appears it is really hard to reach agreement about this, so another alternative is I submit a bug report about the L1 invalidation problem and leave it to you to figure this out. In the mean time, we will fix the bug only in our private fork of lldb. Greg, perhaps you would prefer that?

I don't see this as really that hard to fix correctly. Feel free to do what you need to if this is too much.

Apr 11 2020, 1:34 AM · Restricted Project

Apr 10 2020

jarin added a comment to D77790: [NFC] Add a test for the inferior memory cache (mainly L1).

Regarding the callback idea, I have bad experience with callbacks because they break if the code is not crafted for re-entrancy and they are much harder to understand. That change feels out of scope for just adding a test and fixing an unrelated bug.

Apr 10 2020, 3:12 AM · Restricted Project

Apr 9 2020

jarin added a comment to D77765: Fix incorrect L1 inferior memory cache flushing.

As labath@ suggested, I have teased apart the test and the testability refactoring into a separate patch. The patch lives at https://reviews.llvm.org/D77790, could you please take a look?

Apr 9 2020, 7:01 AM · Restricted Project
jarin updated the diff for D77790: [NFC] Add a test for the inferior memory cache (mainly L1).

Addressed reviewer comments.

Apr 9 2020, 5:55 AM · Restricted Project
jarin added inline comments to D77790: [NFC] Add a test for the inferior memory cache (mainly L1).
Apr 9 2020, 5:55 AM · Restricted Project
jarin created D77790: [NFC] Add a test for the inferior memory cache (mainly L1).
Apr 9 2020, 4:50 AM · Restricted Project
jarin added a comment to D77765: Fix incorrect L1 inferior memory cache flushing.

I rewrote parts of the test, hopefully making it a bit clearer. Please let me know if this made it better.

Apr 9 2020, 1:03 AM · Restricted Project
jarin updated the diff for D77765: Fix incorrect L1 inferior memory cache flushing.

Addressed some of the reviewer comments.

Apr 9 2020, 1:03 AM · Restricted Project

Apr 8 2020

jarin retitled D77765: Fix incorrect L1 inferior memory cache flushing from Fix incorrect L1 cache flushing to Fix incorrect L1 inferior memory cache flushing.
Apr 8 2020, 4:51 PM · Restricted Project
jarin created D77765: Fix incorrect L1 inferior memory cache flushing.
Apr 8 2020, 4:51 PM · Restricted Project

Apr 7 2020

jarin added a comment to D74398: [lldb-server] jThreadsInfo returns stack memory.

Looking at the code for flushing L1 cache, it appears broken. I am guessing that is the reason for the failure of my patch on the bots.

Apr 7 2020, 6:28 AM · Restricted Project