This is an archive of the discontinued LLVM Phabricator instance.

[PGO] Enable memcmp/bcmp size value profiling.
ClosedPublic

Authored by hjyamauchi on May 26 2020, 11:09 AM.

Diff Detail

Event Timeline

hjyamauchi created this revision.May 26 2020, 11:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2020, 11:09 AM
Herald added a subscriber: hiraditya. · View Herald Transcript

What is the profile size increase with this change (e.g with Clang's profile)?

~0.04% increase in Clang's profile.

Before 37554248
After 37570080 (1.000421x)

This flag only guarded the optimization side. I uploaded D80646 to also have the instrumentation side behind the flag before enabling it.

davidxl accepted this revision.Jun 1 2020, 12:35 PM

lgtm

This revision is now accepted and ready to land.Jun 1 2020, 12:35 PM
This revision was automatically updated to reflect the committed changes.